-
Notifications
You must be signed in to change notification settings - Fork 39
ceno-cli conntinuation proofs e2e #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
fec3589 to
a210d89
Compare
hero78119
commented
Oct 29, 2025
Collaborator
Author
|
Collaborator
|
kunxian-xia
reviewed
Nov 5, 2025
Collaborator
kunxian-xia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st pass of code review
867523f to
1cf13c9
Compare
kunxian-xia
approved these changes
Nov 5, 2025
Collaborator
kunxian-xia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #1092
change scopes
design rationales
prover_idandnum_proversare exposed as CLI arguments to specify the number of physical provers in a cluster, each mark with a prover_id. The overall trace data is divided intoshards, which are distributed evenly among the provers. The number of shards are in general agnostic to number of provers. Each prover is assignednshard where n can be even emptyShard distribution follows a balanced allocation strategy — for example, if there are 10 shards and 3 provers, the shard counts will be distributed as 4, 3, and 3, ensuring an even workload across all provers.