Skip to content

chore: merge upstream f67629fe9 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 279 commits into from
Jul 9, 2025
Merged

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jul 4, 2025

No description provided.

RomanHodulak and others added 30 commits June 13, 2025 20:49
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Alexey Shekhirin <[email protected]>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
mattsse and others added 18 commits June 27, 2025 16:33
Signed-off-by: Gregory Edison <[email protected]>
Copy link

codspeed-hq bot commented Jul 9, 2025

CodSpeed Performance Report

Merging #274 will improve performances by 52.55%

Comparing chore-merge-upstream-f67629fe9 (1f10b3b) with scroll (766dd27)

Summary

⚡ 43 improvements
✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
prefix set | size: 10 | `BTreeSet` with `BTreeSet:range` lookup 6.2 µs 5.1 µs +20.07%
prefix set | size: 10 | `BTreeSet` with `Iterator:any` lookup 5.1 µs 3.9 µs +30.21%
prefix set | size: 10 | `Vec` with binary search lookup 4.7 µs 3.8 µs +23.7%
prefix set | size: 10 | `Vec` with custom cursor lookup 4.5 µs 3.2 µs +38.5%
prefix set | size: 100 | `BTreeSet` with `BTreeSet:range` lookup 53.7 µs 40.2 µs +33.67%
prefix set | size: 100 | `BTreeSet` with `Iterator:any` lookup 198.1 µs 149.3 µs +32.66%
prefix set | size: 100 | `Vec` with binary search lookup 29 µs 19 µs +52.55%
prefix set | size: 100 | `Vec` with custom cursor lookup 24.1 µs 16.1 µs +49.37%
prefix set | size: 1000 | `BTreeSet` with `BTreeSet:range` lookup 597.6 µs 465.5 µs +28.38%
prefix set | size: 1000 | `BTreeSet` with `Iterator:any` lookup 19.7 ms 14.9 ms +32.27%
prefix set | size: 1000 | `Vec` with binary search lookup 294.7 µs 198.3 µs +48.64%
prefix set | size: 1000 | `Vec` with custom cursor lookup 207.1 µs 138.4 µs +49.6%
size 100000 | updated 0.1% | depth 0 4 ms 3.4 ms +15.5%
size 100000 | updated 0.1% | depth 1 4 ms 3.4 ms +15.67%
size 100000 | updated 0.1% | depth 2 3.8 ms 3.3 ms +16.22%
size 100000 | updated 0.1% | depth 3 2.8 ms 2.3 ms +19.35%
size 100000 | updated 0.1% | depth 4 1.6 ms 1.3 ms +28.03%
size 100000 | updated 0.1% | depth 5 1,318 µs 989.8 µs +33.16%
size 100000 | updated 1% | depth 0 26.8 ms 23.8 ms +12.38%
size 100000 | updated 1% | depth 1 26.8 ms 23.9 ms +12.4%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@frisitano
Copy link
Collaborator

I have tested compact-codec locally and it's working fine. CI failure will resolve upon merge to main.

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frisitano frisitano merged commit aad1706 into scroll Jul 9, 2025
41 of 44 checks passed
@frisitano frisitano deleted the chore-merge-upstream-f67629fe9 branch July 9, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.