Skip to content

feat: support local genesis file #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: support local genesis file #250

wants to merge 4 commits into from

Conversation

colinlyguo
Copy link
Member

Closes: #217.

@colinlyguo colinlyguo requested a review from greged93 August 12, 2025 18:12
@colinlyguo colinlyguo force-pushed the feat-support-genesis-file branch 3 times, most recently from dc663e6 to a0a04a1 Compare August 12, 2025 18:49
@colinlyguo colinlyguo force-pushed the feat-support-genesis-file branch from a0a04a1 to e3bb57f Compare August 12, 2025 18:52
greged93
greged93 reviewed Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment otherwise looks good!

@colinlyguo colinlyguo requested a review from greged93 August 15, 2025 08:09
@yiweichi yiweichi self-requested a review August 15, 2025 08:23
yiweichi
yiweichi approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@yiweichi yiweichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

frisitano
frisitano requested changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be good if we could add an e2e integration test in which we spin up 1 sequencer and 1 follower node with a local chain spec / custom genesis and ensure we the chain can produce blocks.

@colinlyguo
Copy link
Member Author

Looks good! It would be good if we could add an e2e integration test in which we spin up 1 sequencer and 1 follower node with a local chain spec / custom genesis and ensure we the chain can produce blocks.

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frisitano frisitano frisitano requested changes

@yiweichi yiweichi yiweichi approved these changes

@greged93 greged93 Awaiting requested review from greged93

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for custom genesis configuration in rollup-node
4 participants
@colinlyguo @frisitano @yiweichi @greged93