Skip to content

[FIX] For testing chunk with witness from TRACE_PATH, read new witness format by default #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[FIX] For testing chunk with witness from TRACE_PATH, read new witness format by default #192

wants to merge 3 commits into from

Conversation

@noel2004
Copy link
Member

The new witnesses being dump and tested with specifying TRACE_PATH in integration_test has been expected to be generated with new format. While read_block_witness method still read them with legacy defination. This PR fix the issue and also keep compatibility with the current test data samples (still in old format)

@github-actions github-actions bot added the crate-integration Updates to the integration crate label Sep 22, 2025
@noel2004 noel2004 requested review from lightsing and lispc September 22, 2025 04:07
@lispc
Copy link
Collaborator

lispc commented Sep 22, 2025

  1. dont use env var. Just try to load in one format, if it fails, try another format.
  2. rename the new test to sth like test_load_witness_file. of course we can still print ommer block hash inside.

@github-actions github-actions bot added crate-chunk-circuit Updates to the guest program chunk-circuit crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-prover Updates to the prover crate crate-circuits Any update made to the circuits, i.e. commitments reflect a change labels Sep 22, 2025
@noel2004
Copy link
Member Author

  1. dont use env var. Just try to load in one format, if it fails, try another format.
  2. rename the new test to sth like test_load_witness_file. of course we can still print ommer block hash inside.
  1. fixed
  2. The new test is some temporary code and being added by mistake so I simply prune them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lispc lispc Awaiting requested review from lispc lispc is a code owner

@lightsing lightsing Awaiting requested review from lightsing lightsing is a code owner

@roynalnaruto roynalnaruto Awaiting requested review from roynalnaruto roynalnaruto is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

crate-batch-circuit Updates to the guest program batch-circuit crate-bundle-circuit Updates to the guest grogram bundle-circuit crate-chunk-circuit Updates to the guest program chunk-circuit crate-circuits Any update made to the circuits, i.e. commitments reflect a change crate-integration Updates to the integration crate crate-prover Updates to the prover crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noel2004 @lispc @Velaciela