Misc data updates #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch module to esnext * add game_changer card field * revert module config change * add spree frame effect * add note to readme about transpilation for use of enums at runtime * reword
billdami
commented
Aug 22, 2025
| @@ -88,6 +88,8 @@ All primary types and values are prefixed with `Scryfall` to avoid conflict with | |||
|
|
|||
| Enum fields are described both in terms of an enum and a set of strings in order to give you the option of interacting with that field with either one. | |||
|
|
|||
| In order to use the provided enum values in runtime code (i.e. outside of just compile-time type checking), you may need to configure your project's build pipeline/module bundler to ensure it is transpiling the Typescript source code in the `@scryfall/api-types` package. Many module bundlers exclude `node_modules` from Typescript transpilation for performance reasons, but provide methods to force inclusion of specific paths (e.g. Webpack's `module.rules`, or Next.js's `transpilePackages` configurations). | |||
There was a problem hiding this comment.
I don't know how commonly people run into this issue, but it happened to me, so it felt worth pointing out. The better option might be to transpile src/ on publish, so it just works out-of-the-box in all envs, but a quick note seemed sufficient in lieu of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
game_changerCard fieldSpreeFrameEffect