fix(ci): bump Go to 1.26.6 — clears reachable stdlib advisories in vuln scan - #885
Open
madeinoz67 wants to merge 1 commit into
Open
fix(ci): bump Go to 1.26.6 — clears reachable stdlib advisories in vuln scan#885madeinoz67 wants to merge 1 commit into
madeinoz67 wants to merge 1 commit into
Conversation
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop's CI is red on the Vulnerability scan — and so is every open PR against it, including #874. This bumps the
godirective one patch release to clear it.Problem
develop@34b505f(run 32142058965) failsVulnerability scan— the only failing job.govulncheck@v1.6.0reports 6 reachable Go standard-library advisories against the pinnedgo 1.26.5:These advisories postdate the last green run (Aug 12) — the scan didn't regress from any commit; the vuln DB moved. All findings are stdlib/toolchain-level; no module dependency is involved.
Fix
One line:
go 1.26.5→go 1.26.6ingo.mod. All five CI jobs resolve their toolchain viago-version-file: go.mod, so no workflow changes are needed. Notoolchaindirective is introduced (the repo doesn't use one); the directive floor is the mechanism CI already reads. No dependency changes.Verification
go build -tags localassets ./... && go vet -tags localassets ./... && gofmt -l .— clean on 1.26.6.govulncheck@v1.6.0 ./...(same version CI pins) on the bumped tree: "Your code is affected by 0 vulnerabilities" — all 6 reachable stdlib findings gone. 3 unreachable module-level findings remain; those are pre-existing and non-failing (the scan gates on reachable code).internal/plugin/embed,internal/mcp,internal/metrics,internal/replication/tls.go,cmd/muninn/doctor.go).Effect
Once this lands, #874's
Vulnerability scancheck clears (its red is inherited from develop, not from that PR's diff — the sole file overlap,internal/transport/grpc/server.go, flags a pre-existinggrpc.Server.Serve→ tls path unchanged by #874).