Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #280 +/- ##
==========================================
+ Coverage 55.87% 57.02% +1.14%
==========================================
Files 29 29
Lines 9392 9421 +29
==========================================
+ Hits 5248 5372 +124
+ Misses 4144 4049 -95 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FASTA file ending in a header without a sequence can silently reuse the preceding record's sequence. For example,
>first\nACGT\n>missing\nreturns(['first', 'missing'], ['ACGT', 'ACGT']), potentially mislabelling sequence input togget mutate.Reject the unfinished record with
ValueError, consistent with the existing rejection of consecutive headers. Ignore blank lines so they cannot hide a missing sequence. Complete records retain their output, including multiline sequences and files without a final newline. Zero-byte file handling is unchanged.Adds 16 synthetic regression cases and a changelog entry.
Validation (Python 3.12.3, normal package imports):
bc7b353ea2215cba00697591c33887b1094c660b: 9 failed, 8 passed.git diff --checkpassed. The full live-service test suite and lint/type-check matrix were not run locally.AI assistance: OpenAI Codex assisted with investigation, implementation, tests, changelog, and this description. The human contributor reviewed and approved the missing-sequence error behavior and main validation conditions before this commit. The tests above were executed by Codex; this disclosure does not claim a human independently ran them.