Repository navigation
Accept hdi_prob in scCODA summaries with arviz 1.x - #1159
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
==========================================
+ Coverage 75.67% 75.69% +0.02%
==========================================
Files 55 55
Lines 8431 8435 +4
==========================================
+ Hits 6380 6385 +5
+ Misses 2051 2050 -1
🚀 New features to boost your workflow:
|
Zethson
force-pushed
the
fix/coda-arviz-ci-prob
branch
from
October 2, 2026 11:02
b50b967 to
4d30083
Compare
arviz 1.x renamed the summary interval keyword from hdi_prob to ci_prob and names the columns hdi80_lb/hdi80_ub, so the documented hdi_prob= call raised a TypeError and HDI columns were never prettified. summary_prepare now takes hdi_prob explicitly, forwards it as ci_prob with ci_kind="hdi", and the column renaming handles both HDI and ETI names. Default output is unchanged and hdi_prob=0.8 matches ci_prob=0.8, ci_kind="hdi" exactly on haber_2017_regions.
Zethson
force-pushed
the
fix/coda-arviz-ci-prob
branch
from
October 2, 2026 11:02
4d30083 to
8b34a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary_prepareandsummaryaccepthdi_probagain and forward it to arviz 1.x asci_probwithci_kind="hdi", and HDI columns are labelledHDI X% lower/upperlike the ETI ones.The documented
sccoda.summary(mdata, hdi_prob=0.8)call no longer raisesTypeError.