Repository navigation
Stop rendering scCODA trees inline after saving - #1161
Merged
Merged
Conversation
plot_draw_tree and plot_draw_effects rendered the tree a second time with "%%inline" after writing the requested file, which requires IPython and failed in plain scripts although the file had already been written. Return after saving unless a figure is requested, and write the intermediate tree image of show_leaf_effects to a temporary directory instead of the working directory. Notebook behaviour without save is unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 75.67% 75.67%
=======================================
Files 55 55
Lines 8431 8432 +1
=======================================
+ Hits 6380 6381 +1
Misses 2051 2051
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plot_draw_treeandplot_draw_effectsno longer render the tree inline after writingsave, which required IPython and failed outside notebooks, and the intermediate image forshow_leaf_effectsgoes to a temporary directory.Saving tree plots works from scripts and no longer leaves
tree_effect.pngin the working directory.