Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom dataloader registry support #2932

Open
wants to merge 120 commits into
base: main
Choose a base branch
from

Conversation

ori-kron-wis
Copy link
Collaborator

No description provided.

@ori-kron-wis ori-kron-wis added this to the scvi-tools 1.2 milestone Aug 7, 2024
@ori-kron-wis ori-kron-wis self-assigned this Aug 7, 2024
@ori-kron-wis ori-kron-wis linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 45.04505% with 305 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (d0abcdc) to head (4e1dcaf).

Files with missing lines Patch % Lines
src/scvi/dataloaders/_custom_dataloders.py 40.06% 190 Missing ⚠️
src/scvi/model/base/_base_model.py 37.28% 74 Missing ⚠️
src/scvi/model/_scanvi.py 56.09% 18 Missing ⚠️
src/scvi/model/_scvi.py 50.00% 12 Missing ⚠️
src/scvi/model/base/_archesmixin.py 77.41% 7 Missing ⚠️
src/scvi/model/base/_training_mixin.py 76.92% 3 Missing ⚠️
src/scvi/model/base/_save_load.py 90.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d0abcdc) and HEAD (4e1dcaf). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (d0abcdc) HEAD (4e1dcaf)
12 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
- Coverage   86.69%   79.05%   -7.64%     
==========================================
  Files         193      194       +1     
  Lines       17115    17601     +486     
==========================================
- Hits        14838    13915     -923     
- Misses       2277     3686    +1409     
Files with missing lines Coverage Δ
src/scvi/dataloaders/__init__.py 100.00% <100.00%> (ø)
src/scvi/dataloaders/_data_splitting.py 95.47% <ø> (ø)
src/scvi/model/base/_save_load.py 82.17% <90.00%> (-4.14%) ⬇️
src/scvi/model/base/_training_mixin.py 88.38% <76.92%> (-1.42%) ⬇️
src/scvi/model/base/_archesmixin.py 76.36% <77.41%> (-0.53%) ⬇️
src/scvi/model/_scvi.py 80.00% <50.00%> (-15.92%) ⬇️
src/scvi/model/_scanvi.py 79.82% <56.09%> (-13.20%) ⬇️
src/scvi/model/base/_base_model.py 79.38% <37.28%> (-13.49%) ⬇️
src/scvi/dataloaders/_custom_dataloders.py 40.06% <40.06%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

)
else:
# custom datamodule
n_cats_per_cov = self.summary_stats[f"n_{REGISTRY_KEYS.CAT_COVS_KEY}"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work for AnnData? Can we remove the if statement here?

@ori-kron-wis ori-kron-wis added on-merge: backport to 1.3.x on-merge: backport to 1.3.x and removed on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom_dataloader PR 2932 on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix custom dataloader registry
2 participants