-
Notifications
You must be signed in to change notification settings - Fork 17
make outline behavior more similar to squidpy #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 85.00% 85.02% +0.01%
==========================================
Files 8 8
Lines 1794 1856 +62
==========================================
+ Hits 1525 1578 +53
- Misses 269 278 +9
🚀 New features to boost your workflow:
|
Note: when |
Regarding the "outline lies partly behind shape and will shine through if fill_alpha != 1" issue:
|
For outsourcing the plotting from squidpy to spatialdata-plot: refactor the outlines of the shapes to be more similar to squidpy. This includes:
outline_width
andoutline_color
take either a single argument as before, or a tuple of two values referring to the outer and inner outline. If one of the two arguments indicates that 2 outlines should be drawn but the other is not used (or only contains of 1 value which would be interpreted as referring to the outer outline), the missing value(s) are set to the defaults which are for the outer outline: 1.5 and "black" and for the inner outline: 0.5 and "white". If the linewidth for the inner outline is wider than the one of the outer outline, it will hide the outer outline (if alpha = 1.0).