-
Notifications
You must be signed in to change notification settings - Fork 18
Fix NaN handling and transparency in shape rendering #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timtreis
commented
Oct 20, 2025
- Fix KeyError in _convert_shapes by using proper DataFrame indexing
- Improve NaN value handling in color processing to use na_color correctly
- Preserve transparency from colormaps when fill_alpha is specified
- Add support for mixed numeric/color arrays in shape coloring
- Refactor _convert_shapes to use positional indexing for better reliability
- Fix KeyError in _convert_shapes by using proper DataFrame indexing - Improve NaN value handling in color processing to use na_color correctly - Preserve transparency from colormaps when fill_alpha is specified - Add support for mixed numeric/color arrays in shape coloring - Refactor _convert_shapes to use positional indexing for better reliability
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 83.38% 84.42% +1.03%
==========================================
Files 8 8
Lines 2106 2131 +25
==========================================
+ Hits 1756 1799 +43
+ Misses 350 332 -18
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.