Skip to content

Conversation

@timtreis
Copy link
Member

  • Fix KeyError in _convert_shapes by using proper DataFrame indexing
  • Improve NaN value handling in color processing to use na_color correctly
  • Preserve transparency from colormaps when fill_alpha is specified
  • Add support for mixed numeric/color arrays in shape coloring
  • Refactor _convert_shapes to use positional indexing for better reliability

timtreis and others added 13 commits October 20, 2025 22:40
- Fix KeyError in _convert_shapes by using proper DataFrame indexing
- Improve NaN value handling in color processing to use na_color correctly
- Preserve transparency from colormaps when fill_alpha is specified
- Add support for mixed numeric/color arrays in shape coloring
- Refactor _convert_shapes to use positional indexing for better reliability
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 82.41758% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.42%. Comparing base (491dae9) to head (d561e34).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_plot/pl/utils.py 84.90% 24 Missing ⚠️
src/spatialdata_plot/pl/render.py 65.21% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   83.38%   84.42%   +1.03%     
==========================================
  Files           8        8              
  Lines        2106     2131      +25     
==========================================
+ Hits         1756     1799      +43     
+ Misses        350      332      -18     
Files with missing lines Coverage Δ
src/spatialdata_plot/pl/render.py 91.23% <65.21%> (-1.38%) ⬇️
src/spatialdata_plot/pl/utils.py 80.19% <84.90%> (+2.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timtreis timtreis added shapes 🫧 Anything related to Shapes release-fixed labels Oct 21, 2025
@timtreis timtreis merged commit c9bae23 into main Oct 21, 2025
4 checks passed
@timtreis timtreis deleted the fix/nan-handling-and-transparency branch October 21, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-fixed shapes 🫧 Anything related to Shapes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants