Skip to content

Removing Any trait bound from downcast_unchecked to circumvent ICE #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Removing Any trait bound from downcast_unchecked to circumvent ICE #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hv/crates/hv-boxed/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ pub trait Storable<T: ?Sized, U: ?Sized>: Storage<T> {
#[allow(clippy::missing_safety_doc)]
unsafe fn downcast_unchecked(self) -> Self::Downcast
where
U: Any + Sized;
U: Sized;
}

/// Trait describing storage for a given type.
Expand Down Expand Up @@ -122,7 +122,7 @@ impl<T: ?Sized, Space, U: ?Sized> Storable<T, U> for NonCopyable<T, Space> {
type Downcast = NonCopyable<U, Space>;
unsafe fn downcast_unchecked(self) -> Self::Downcast
where
U: Any + Sized,
U: Sized,
{
let size = mem::size_of::<U>();
let mut space = mem::MaybeUninit::<Space>::uninit();
Expand Down Expand Up @@ -206,7 +206,7 @@ impl<T: ?Sized, Space: Copy, U: Copy> Storable<T, U> for Copyable<T, Space> {
type Downcast = Copyable<U, Space>;
unsafe fn downcast_unchecked(self) -> Self::Downcast
where
U: Any + Sized,
U: Sized,
{
let size = mem::size_of::<U>();
let mut space = mem::MaybeUninit::<Space>::uninit();
Expand Down