Skip to content

Conversation

@R-Palazzo
Copy link
Contributor

@R-Palazzo R-Palazzo commented Oct 22, 2025

Resolve #448
CU-86b72r217

In the screenshot, you can see the code that was run to generate the folder structure. Let me know if it makes sense. The one thing I'm unsure about is the UniformSynthesizer, since it now runs at every benchmark_single_table() call.
I also run it on AWS to check that it's working the same way, here are the results

Screenshot 2025-10-22 at 15 59 20

@R-Palazzo R-Palazzo self-assigned this Oct 22, 2025
@R-Palazzo R-Palazzo requested a review from a team as a code owner October 22, 2025 16:54
@sdv-team
Copy link
Contributor

@R-Palazzo R-Palazzo removed the request for review from a team October 22, 2025 16:54
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 75.51020% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.13%. Comparing base (2a418d3) to head (713effc).

Files with missing lines Patch % Lines
sdgym/benchmark.py 79.06% 9 Missing ⚠️
sdgym/result_explorer/result_handler.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   71.98%   72.13%   +0.14%     
==========================================
  Files          27       27              
  Lines        2174     2189      +15     
==========================================
+ Hits         1565     1579      +14     
- Misses        609      610       +1     
Flag Coverage Δ
integration 56.72% <65.30%> (+0.17%) ⬆️
unit 66.14% <67.34%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@R-Palazzo R-Palazzo force-pushed the issu-448-rename-artifacts branch from eef70fe to 829ef81 Compare October 23, 2025 12:08
@R-Palazzo R-Palazzo force-pushed the issu-448-rename-artifacts branch from 25034f4 to 0552f20 Compare October 24, 2025 08:37
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only 1 small comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When performing multiple SDGym runs on the same day, save the artifacts with consistent naming

3 participants