A lot of job-related refactoring #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously static-only methods have been migrated to dedicated utility classes. The overall design is more intuitive now imo. Apart from that, the dedicated classes make for much better autowiring candidates.
(cherry picked from commit 27fecc2)
Yes I am aware I can make it fluent, but for some reason the editor decides to spit out warnings if I don't put a class-level `@Getter`. Since the rest of the members should not be accessible, I think that this is acceptable.
Both convert Strings to either JsonArray or JsonPrimitive
Spring already has an autoconfiguration that adds it. This is wholly unnecessary.
Web-related thigs will go there from now on
The stream now includes both the ID, along with the name. While not wholly necessary, does improve debugging at no cost whatsoever.
The only difference now is that the process is more optimized. It will be triggered every monday, streaming through all repositories that have not been pinged for more than 5 weeks. At the same time, it performs the old ls-remote check, with a cURL fallback. If the repository can not be reached by either means, it is deleted. Otherwise, we update the ping value.
(cherry picked from commit eacaed6)
Instead of using a single lock for creation, we now use a ReadWriteLock. In essence, any number of threads can acquire read locks, but as soon as a write lock is acquired all other threads will have to wait.
I think the listener is only useful in cases where the annotation is used. When doing programmatic retries, we can just inject the logger from the parent class, and have a more direct degree of control over what we log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of changes, but most notably: reverting cleaner back to a Stream-centric implementation. Furthermore, the static code analysis component has been merged into the job itself.