Improve some serialisation aspects of CSV fromat #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why we did this in the first place. I guess whoever implemented this never bothered to check if the lists can be serialized in CSV. By using the default serialization we also inadvertently save up on space, as empty arrays will not be printed as `[]` to the CSV, but rather a `null` in the form of an empty column value.
We removed both `GitRepoCsvDto` and its converter. I feel like an inaccessible inner class is more fitting, since we can access the `JsonMapper` from the outer class, and define the adepter code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were made to both clean up the code, as well as increase the efficiency of the format by cutting down on redundant data. Although we still serialize nested objects in CSV as JSONs, we did change the list serialization format from a JSON String Array to a semicolon-delimited string format.