refactor(target): centralize and simplify target resolution#365
Draft
tris203 wants to merge 6 commits into
Draft
refactor(target): centralize and simplify target resolution#365tris203 wants to merge 6 commits into
tris203 wants to merge 6 commits into
Conversation
Move solution and project target resolution logic from sln/utils to a new roslyn/target module, consolidating related logic and improving clarity. Update all usages to reference the new module. Remove the now-redundant sln/utils module. Refactor store to clarify client/selected target handling and add sync helper. Update autocmd and health checks to use the new store API. Add comprehensive tests for target resolution logic. BREAKING CHANGE: sln/utils is removed; use roslyn/target instead for target prediction and resolution.
Replaced pattern matching and list traversals with table lookups for extensions and ignored directories. This improves the performance of solution and project file discovery, especially in large codebases. Also simplified target filtering and ambiguous root resolution logic.
Refactored the predict_target function to streamline its logic by removing the intermediate result variable and directly returning the chosen or filtered target. Also moved the logging of the selected target to the resolve_open_target function for better separation of concerns.
I felt like it was too many exposed methods from the store module. We can keep the API surface smaller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move solution and project target resolution logic from sln/utils to a new roslyn/target module, consolidating related logic and improving clarity. Update all usages to reference the new module. Remove the now-redundant sln/utils module. Refactor store to clarify client/selected target handling and add sync helper. Update autocmd and health checks to use the new store API. Add comprehensive tests for target resolution logic.
BREAKING CHANGE: sln/utils is removed; use roslyn/target instead for target prediction and resolution.