feature: meeting transcriber by gbrunoo · Pull Request #61 · sebsto/wispr

gbrunoo · 2026-04-29T21:11:03Z

adding the possibility to record meetings by recording from own microphone and from the computer audio stream. the two transcript stay separate and can then subsequently copied elsewhere

sebsto

Hello, @gbrunoo Thank you so much for this submission ! This will add a much demanded capability to the app.

I left a few comments

files that should not be part of the commit
questions about the mode operation that influence the onboarding
IMHO, the onboarding flow should not be touched by this change

Also, there is no test for the new audio engine and state manager. Can you add some to verify the logic / state of these two new components ?

Please answer on the comments. I will pull these changes in and compile / test the next version.

sebsto · 2026-05-02T14:07:48Z

Can you remove this file ?

sebsto · 2026-05-02T14:08:08Z

Can you remove this file

sebsto · 2026-05-02T14:09:23Z

This file should not be committed to the project.

sebsto · 2026-05-02T14:11:13Z

+
+    /// Called when the user closes the window via the red X button.
+    /// Syncs `isWindowVisible` back to false so the menu item can reopen it.
+    nonisolated func windowWillClose(_ notification: Notification) {


The default SwiftUI views are isolated to MainActor. Why declare it nonisolated and the run the code in a MainActor isolated block ? I may miss something, otherwise this can be simplified.

sebsto · 2026-05-02T14:13:53Z

I don't understand why adding / heading steps in the onboarding flows.
I think I understand you changed the app to work in a different mode for meeting transcription. Either teh app install itself as a meeting transcription either as dictation. If this is the case, this must be changed :-) The app should stay polyvalent and work with two different activations mode : transcript or dictation and user must be able to use one or the other easily (typically, two different actions) - not a persistent mode.

IMHO, the onboarding flow must not be modified to support this new capability

The meeting transcriber requires additional rights as the app can record the system sounds. If not included on the onboarding the user will have to manually add the rights on the first attempt to use the meeting transcriber

sebsto · 2026-05-02T14:16:01Z

+
+    /// When true, the app is running as the meeting transcription variant.
+    /// Disables features that require accessibility permission (text insertion at cursor).
+    var isMeetingMode: Bool = false


As described in my previous comment. OK to work in meeting mode temporaly. If this is needed we can leave it as-is. But onboarding can not be touched by this

sebsto · 2026-05-02T14:16:56Z

Why the changes in this file ?

sebsto · 2026-05-02T14:17:42Z

This file should not be part of the commit

- Remove isMeetingMode from SettingsStore - Revert onboarding flow to not skip accessibility permission - Revert app name to 'Wispr' (from 'Wispr Steno') - Revert bundle identifier to com.stormacq.mac.wispr - Revert development team to original - Meeting transcription is now a separate menu action users can trigger on-demand - Users can switch between dictation and meeting transcription dynamically This addresses maintainer feedback: the app should be polyvalent, allowing users to easily use both dictation and meeting transcription without choosing a persistent mode during onboarding.

sebsto · 2026-05-02T20:36:50Z

Hello @gbrunoo Thank you fo rthe new commits. Now, there 128 files changed in the project.
This is too big to review. Looks like most file haven't really be touched, just the permission.
Can you revert that and only send the files that have actually be changed ?
Thank you

sebsto

Thank you for having reverted the multi mode aspects. Looks liek your force push changed the permission on all projects files. This PR now touches 128 files, most of them with a permission change. Can you revert this to only send the files that have actually be changed ?
also, the task/toto.md must be renamed and placed into .kiro/specs directory.
Thank you

- Fix file permissions (100755 → 100644) on all files - Move tasks/todo.md to .kiro/specs/meeting-transcription/design.md - Revert files that should not be in PR: project.pbxproj, OnboardingFlow.swift, .vscode/settings.json, ModelPaths.swift, SettingsStore.swift - Fix MenuBarControllerTests for new meetingStateManager parameter - Add MeetingAudioEngineTests (8 tests): stream behavior, safe no-ops, capture failure handling, double-start guard - Add MeetingStateManagerTests (14 tests): transcript model formatting, state lifecycle, error handling, copy transcript, double-start prevention

Address PR feedback: fix permissions, add tests, clean up

Add NSWindowDelegate conformance to MeetingWindowPanel so that windowWillClose syncs isVisible back to false. Without this, the guard in show() would early-return because isVisible was stale.

Fix: meeting window can be reopened after closing via red X button

sebsto · 2026-05-03T15:20:48Z

Thank you @gbrunoo This is much easier to read.
Look great in general, but with a lot of points that are non compliant with Swift 6 structures concurrency (@unchecked Sendable, unmanaged Tasks, nonisolated(unsafe) etc)

Use the Kiro power skill to direct AI Coding agent towards the correct set of rules
https://github.com/sebsto/swift-kiro-power

sebsto

Much better now - still a couple of lines that are not compliant with swift 6 structred concurrency rules

sebsto · 2026-05-03T15:26:24Z

+// MARK: - ScreenCaptureKit Audio Output Handler
+
+/// Receives audio sample buffers from SCStream and converts them to Float32 arrays.
+final class SystemAudioOutputHandler: NSObject, SCStreamOutput, @unchecked Sendable {


final class SystemAudioOutputHandler: NSObject, SCStreamOutput, @unchecked Sendable { private let onSamples: @Sendable ([Float]) -> Void

The class is final, its sole stored property is an immutable let of @Sendable closure type, and NSObject is already @unchecked Sendable in the SDK. The compiler can verify Sendable conformance directly — @unchecked is not needed and bypasses that verification.

Severity: Low
Fix: Replace @unchecked Sendable with plain Sendable.

sebsto · 2026-05-03T15:28:55Z

+/// entries until system audio support is added.
+@MainActor
+@Observable
+final class MeetingStateManager {


MeetingStateManager is @MainActor. Tasks spawned from its methods inherit MainActor isolation. The await MainActor.run { } wrappers inside those tasks are redundant hops that add overhead and mislead readers into thinking the code is off the main actor.

Location Code

startMicTranscription() await MainActor.run { self.transcript.entries.append(...) }

startSystemTranscription() await MainActor.run { self.transcript.entries.append(...) }

startMicLevelConsumption() await MainActor.run { self?.micLevel = level }

startSystemLevelConsumption() await MainActor.run { self?.systemLevel = level }

startTimer() await MainActor.run { self?.elapsedTime = ... }

Severity: Low
Fix: Remove all five await MainActor.run { } wrappers; access properties directly.

sebsto · 2026-05-03T15:30:07Z

+/// entries until system audio support is added.
+@MainActor
+@Observable
+final class MeetingStateManager {


The manager spawns five unstructured Task { } stored in properties and manually cancelled in stopMeeting():

Property Spawned in

micTranscriptionTask startMicTranscription()

systemTranscriptionTask startSystemTranscription()

micLevelTask startMicLevelConsumption(_:)

systemLevelTask startSystemLevelConsumption(_:)

timerTask startTimer()

If stopMeeting() is never called (e.g. the manager is deallocated while recording), the tasks leak and keep running. There is no deinit safety net.

Severity: Medium
Fix: Replace the five independent tasks with a single withTaskGroup launched from startMeeting(). The group naturally cancels all child tasks when the parent scope exits. Alternatively, store a single parent Task that spawns child tasks via async let or a task group, so cancelling the parent cascades to all children.

sebsto · 2026-05-03T15:30:44Z

+///
+/// If system audio capture fails (e.g. permission denied, sandbox restriction),
+/// the engine continues with mic-only capture and logs a warning.
+actor MeetingAudioEngine {


// In installTap closure Task { await self.processMicSamples(samples) } // In SystemAudioOutputHandler callback Task { await self.processSystemSamples(samples) }

Each audio buffer spawns a new unstructured Task to hop into the actor's isolation domain. Under heavy audio load this creates many short-lived tasks with no backpressure.

Severity: Low-Medium
Fix: Use an AsyncStream as the bridge instead — the tap yields samples into a continuation, and a single structured task consumes them inside the actor. This gives natural backpressure and one task instead of hundreds.

sebsto · 2026-05-03T15:31:41Z

        permissionMonitoringTask?.cancel()
        updateCheckTask?.cancel()

+        // Stop any active meeting session


if let msm = meetingStateManager { Task { await msm.stopMeeting() } }

This spawns an unstructured task during app termination. The process may exit before the task completes, meaning stopMeeting() (which flushes buffers, cancels child tasks, stops audio capture) may never finish.

Severity: Medium
Fix: await the stop synchronously (acceptable at termination)

@unchecked

MeetingAudioEngine: - Replace per-buffer Task spawning with AsyncStream bridge pattern. Tap callbacks yield into continuations; single consumer tasks on the actor read from the streams. Eliminates hundreds of short-lived tasks under heavy audio load and provides natural backpressure. - Replace @unchecked Sendable with plain Sendable on SystemAudioOutputHandler (final class with immutable let property). MeetingStateManager: - Remove 5 redundant await MainActor.run {} wrappers. Since the class is @mainactor, spawned Tasks inherit isolation — direct property access is correct. - Replace 5 unstructured Task properties with single recordingTask using withTaskGroup. Cancelling the parent cascades to all children. Add cancelRecording() for synchronous cancellation at app termination. wisprApp: - Replace fire-and-forget Task { await msm.stopMeeting() } in applicationWillTerminate with synchronous cancelRecording() call.

Refactor for Swift 6 structured concurrency compliance

gbrunoo · 2026-05-04T06:43:13Z

Hi @sebsto, thank you for the thorough review! I've addressed all the feedback:

Swift 6 Structured Concurrency fixes:

MeetingAudioEngine: Replaced per-buffer Task spawning with AsyncStream bridge pattern — tap callbacks yield into continuations, single consumer tasks read on the actor. Eliminates hundreds of short-lived tasks and provides natural backpressure. Also replaced @unchecked Sendable with plain Sendable on SystemAudioOutputHandler.
MeetingStateManager: Removed all 5 redundant await MainActor.run {} wrappers (Tasks inherit @MainActor isolation). Replaced 5 unstructured Task properties with a single recordingTask using withTaskGroup — cancelling the parent cascades to all children. Added cancelRecording() for synchronous cleanup.
wisprApp.swift: Replaced fire-and-forget Task { await msm.stopMeeting() } in applicationWillTerminate with synchronous cancelRecording().

Ready for re-review when you have a chance!

adding meeting transcriptor

2016ea2

sebsto requested changes May 2, 2026

View reviewed changes

sebsto assigned gbrunoo May 2, 2026

sebsto added the enhancement New feature or request label May 2, 2026

gbrunoo force-pushed the main branch from 5353cd1 to 9a00e55 Compare May 2, 2026 17:06

sebsto requested changes May 2, 2026

View reviewed changes

Comment thread .kiro/specs/meeting-transcription/design.md

gbrunoo and others added 4 commits May 3, 2026 10:28

Merge pull request #5 from gbrunoo/meeting-transcriber

a5bb92c

Address PR feedback: fix permissions, add tests, clean up

Fix: meeting window can be reopened after closing via red X button

369a48e

Add NSWindowDelegate conformance to MeetingWindowPanel so that windowWillClose syncs isVisible back to false. Without this, the guard in show() would early-return because isVisible was stale.

Merge pull request #6 from gbrunoo/meeting-transcriber

f1848fc

Fix: meeting window can be reopened after closing via red X button

sebsto requested changes May 3, 2026

View reviewed changes

gbrunoo and others added 2 commits May 4, 2026 08:38

Merge pull request #7 from gbrunoo/meeting-transcriber

5abd62e

Refactor for Swift 6 structured concurrency compliance

sebsto closed this May 4, 2026

Location	Code
`startMicTranscription()`	`await MainActor.run { self.transcript.entries.append(...) }`
`startSystemTranscription()`	`await MainActor.run { self.transcript.entries.append(...) }`
`startMicLevelConsumption()`	`await MainActor.run { self?.micLevel = level }`
`startSystemLevelConsumption()`	`await MainActor.run { self?.systemLevel = level }`
`startTimer()`	`await MainActor.run { self?.elapsedTime = ... }`

Property	Spawned in
`micTranscriptionTask`	`startMicTranscription()`
`systemTranscriptionTask`	`startSystemTranscription()`
`micLevelTask`	`startMicLevelConsumption(_:)`
`systemLevelTask`	`startSystemLevelConsumption(_:)`
`timerTask`	`startTimer()`

Uh oh!

Conversation

gbrunoo commented Apr 29, 2026

Uh oh!

sebsto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebsto commented May 2, 2026

Uh oh!

sebsto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebsto commented May 3, 2026

Uh oh!

sebsto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gbrunoo commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants