Skip to content

fix(agents): slack context explicit-zero + gollem v0.27.0#227

Merged
m-mizutani merged 3 commits into
mainfrom
fix/gollem-typed-tool-followups
Jul 1, 2026
Merged

fix(agents): slack context explicit-zero + gollem v0.27.0#227
m-mizutani merged 3 commits into
mainfrom
fix/gollem-typed-tool-followups

Conversation

@m-mizutani

Copy link
Copy Markdown
Contributor

Follow-up to #226. Addresses review feedback on the typed-tool migration and picks up the tagged gollem release.

Changes

Fix: honor explicit before/after = 0 in the Slack context tool

agents/slack slack_get_context_messages regressed when the typed migration replaced the raw arg read with a > 0 guard: an explicit before: 0 (meaning "fetch nothing before, only after") was collapsed into the default of 10. A typed value field cannot distinguish an omitted argument from an explicit 0.

  • Before / After are now *float64: nil (omitted) → default 10, a non-nil value (including 0) is honored as-is.
  • The pointer is unwrapped to float64 for schema inference, so the wire type stays number — no schema change.
  • Added TestInternalTool_GetContextMessages_ExplicitZeroSkipsSide covering the explicit-zero path.

(The > 0 defaulting for limit / count / page elsewhere is intentional — 0 / negative counts are meaningless there, so it is a robustness improvement, not a regression.)

Cleanup: bigquery config-tool constructor

newConfigGeneratorTools previously took a pre-built *configGeneratorTools and returned the same pointer ("a constructor taking its own output type"). It now takes the individual fields and constructs the value itself.

Deps: gollem → v0.27.0

Moves off the main pseudo-version pulled in by #226 to the tagged v0.27.0 release. The typed-tool / schema APIs are byte-for-byte identical to the pseudo-version, so this is a pin-to-release with no behavior change.

Test

  • go vet ./..., go test ./... — all pass.
  • golangci-lint run, gofmt -l — clean.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gollem dependency to v0.27.0, refactors the Slack agent's context message tool to use pointer types for Before and After parameters to support explicit zero values, and adds a regression test. It also refactors the BigQuery helper's newConfigGeneratorTools constructor to accept individual arguments. The review feedback correctly points out that the tableDatasetID and tableTableID parameters are unused and suggests removing them to simplify the constructor.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkg/tool/bigquery/helper.go
Comment thread pkg/tool/bigquery/helper.go Outdated
@m-mizutani
m-mizutani merged commit 262912b into main Jul 1, 2026
7 checks passed
@m-mizutani
m-mizutani deleted the fix/gollem-typed-tool-followups branch July 1, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant