fix(agents): slack context explicit-zero + gollem v0.27.0#227
Conversation
…tidy bigquery config-tool constructor
There was a problem hiding this comment.
Code Review
This pull request updates the gollem dependency to v0.27.0, refactors the Slack agent's context message tool to use pointer types for Before and After parameters to support explicit zero values, and adds a regression test. It also refactors the BigQuery helper's newConfigGeneratorTools constructor to accept individual arguments. The review feedback correctly points out that the tableDatasetID and tableTableID parameters are unused and suggests removing them to simplify the constructor.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…igquery config generator
Follow-up to #226. Addresses review feedback on the typed-tool migration and picks up the tagged gollem release.
Changes
Fix: honor explicit
before/after= 0 in the Slack context toolagents/slackslack_get_context_messagesregressed when the typed migration replaced the raw arg read with a> 0guard: an explicitbefore: 0(meaning "fetch nothing before, only after") was collapsed into the default of 10. A typed value field cannot distinguish an omitted argument from an explicit0.Before/Afterare now*float64:nil(omitted) → default 10, a non-nil value (including 0) is honored as-is.float64for schema inference, so the wire type staysnumber— no schema change.TestInternalTool_GetContextMessages_ExplicitZeroSkipsSidecovering the explicit-zero path.(The
> 0defaulting forlimit/count/pageelsewhere is intentional — 0 / negative counts are meaningless there, so it is a robustness improvement, not a regression.)Cleanup: bigquery config-tool constructor
newConfigGeneratorToolspreviously took a pre-built*configGeneratorToolsand returned the same pointer ("a constructor taking its own output type"). It now takes the individual fields and constructs the value itself.Deps: gollem → v0.27.0
Moves off the
mainpseudo-version pulled in by #226 to the taggedv0.27.0release. The typed-tool / schema APIs are byte-for-byte identical to the pseudo-version, so this is a pin-to-release with no behavior change.Test
go vet ./...,go test ./...— all pass.golangci-lint run,gofmt -l— clean.