Skip to content

Conversation

@Aqil-Ahmad
Copy link
Contributor

@Aqil-Ahmad Aqil-Ahmad commented Oct 18, 2025

Description

Implements planar texture alignment for PBR materials, allowing checkbox to work with PBR texture transforms.

Related Issues

Fixes #2975

Issue Link:


Checklist

Please ensure the following before requesting review:

  • I have provided a clear title and detailed description for this pull request.
  • If useful, I have included media such as screenshots and video to show off my changes.
  • The PR is linked to a relevant issue with sufficient context.
  • I have tested the changes locally and verified they work as intended.
  • All new and existing tests pass.
  • Code follows the project's style guidelines.
  • Documentation has been updated if needed.
  • Any dependent changes have been merged and published in downstream modules
  • I have reviewed the contributing guidelines.

Additional Notes

@github-actions github-actions bot added the c/cpp label Oct 18, 2025
@Aqil-Ahmad
Copy link
Contributor Author

Aqil-Ahmad commented Oct 18, 2025

/claim #2975

@akleshchev akleshchev requested a review from Copilot October 25, 2025 20:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements planar texture alignment support for PBR (Physically Based Rendering) materials, extending the existing alignment functionality that previously only worked with Blinn-Phong materials. The changes enable the planar alignment checkbox to properly function with PBR texture transforms.

Key Changes:

  • Added a new overloaded calcAlignedPlanarTE() method that accepts explicit transform parameters for PBR materials
  • Modified LLPanelFaceSetAlignedTEFunctor to handle both PBR and Blinn-Phong materials based on user selection
  • Updated alignment logic to apply transforms to appropriate PBR texture channels (individual or all channels when "Complete material" is selected)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
indra/newview/llpanelface.cpp Core implementation of PBR-aware planar alignment, including functor modifications and logic to apply transforms to PBR material channels
indra/newview/llface.h Declaration of new overloaded calcAlignedPlanarTE() method accepting explicit transform parameters
indra/newview/llface.cpp Implementation of new overloaded method that calculates alignment using provided transform parameters instead of querying from texture entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Aqil-Ahmad
Copy link
Contributor Author

@akleshchev thanks for review! ci build was failing, i think the errors are not related to what files i changed. should i resolve those in the other files?

@akleshchev
Copy link
Contributor

akleshchev commented Oct 27, 2025

ci build was failing, i think the errors are not related to what files i changed. should i resolve those in the other files?

Doesn't look like your fault, but please update from develop to try and resolve it as it runs fine in other PRs.

@Aqil-Ahmad Aqil-Ahmad force-pushed the pbr-planar-alignment branch from b12ce3e to 396d0f9 Compare October 27, 2025 17:07
@Aqil-Ahmad Aqil-Ahmad force-pushed the pbr-planar-alignment branch from 396d0f9 to dbfa839 Compare October 27, 2025 17:18
@Aqil-Ahmad
Copy link
Contributor Author

but please update from develop to try and resolve it as it runs fine in other PRs.

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PBR Align Planar Faces Not Functioning

2 participants