Async Inventory Loading Implementation #4893
Open
+1,736
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- various improvements - lazily creates the UI wigets for categories when their parent is expanded
Allow builds to be manually triggered
Ansariel
reviewed
Oct 24, 2025
|
|
||
| LLXMLNodePtr referenced_xml; | ||
| std::string xml_filename = mXMLFilename; | ||
| const std::string& xml_filename = mXMLFilename; |
There was a problem hiding this comment.
Holding a reference to mXMLFilename seems pointless as it's only used in the following if-check now.
Ansariel
reviewed
Oct 24, 2025
|
|
||
| namespace | ||
| { | ||
| class LLAsyncInventorySkeletonLoader |
There was a problem hiding this comment.
Move this class into its own file maybe?
akleshchev
reviewed
Oct 24, 2025
| mSawCurrentOutfitFolder = true; | ||
| LLViewerInventoryCategory* cof = gInventory.getCategory(cof_id); | ||
| const S32 cached_version = gInventory.getCachedCategoryVersion(cof_id); | ||
| if (isCategoryUpToDate(cof, cached_version)) |
There was a problem hiding this comment.
Please add to test plan:
- Log in on machine A. Log out
- Wear an outfit with multiple items of the same type on machine B. Log out.
- Log in on machine A. Change outfit order. Log out.
- Log in on machine B. Confirm order of items.
akleshchev
reviewed
Oct 24, 2025
| // If we run out of time, this still should create root folders | ||
| buildNewViews(gInventory.getRootFolderID()); // My Inventory | ||
| buildNewViews(gInventory.getLibraryRootFolderID()); // Library | ||
| // Build only root widgets - children will load on-demand when expanded |
There was a problem hiding this comment.
Loading 'on demand' potentilly breaks search (assuming it's permanent and not 'on demand untill something in the background eventually gets to it'.
Things to test:
- Recent tab should show recent items since last logoff
- Favorites tab should populate
- Create an item, assign a texture, relog, confirm texture was selected in picker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Introduces asynchronous inventory skeleton loading via AIS to accelerate login (up to 12s faster for 100k+ item inventories) by hydrating from cache, fetching essentials on-demand, and throttling UI updates. Adds debug settings for concurrency/timeouts, fixes cache persistence/dehydration, and optimizes UI with lazy folder widget creation (O(n) parent-child mapping via caching).
Testing:
QA-only
ForceAsyncInventorySkeletontoggle; monitor login times/cache integrity. No breaking changes.