Add serializd tuf root E2E test - #39
Merged
Merged
Conversation
Reviewer's GuideThis PR introduces an end-to-end test for installing a serialized TUF root, extending the test utilities to mirror and package a TUF repository, updating module dependencies, and adding CR templates and a test suite for serialized root installation. Class diagram for new E2E serialized TUF root test utilitiesclassDiagram
class RhtasUtils {
+MirrorTUFRepo()
+PackageTUFRepo()
...
}
class SerializedTUFRootInstallTest {
+TestInstallSerializedTUFRoot()
...
}
RhtasUtils <.. SerializedTUFRootInstallTest : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @JasonPowr - I've reviewed your changes - here's some feedback:
- In tarDir you defer gw.Close() and tw.Close() but never check their returned errors—capture and return those Close() errors to avoid hiding I/O failures when writing the tarball.
- os.MkdirTemp is invoked with "." which creates temp dirs in the repo root—pass an empty string ("" as the first arg) to use the system temp directory and avoid polluting your working tree.
- TufMirrorFS buffers the entire gzipped tar in memory before returning—consider streaming to a file or using an io.Pipe to reduce peak memory usage for large repositories.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In tarDir you defer gw.Close() and tw.Close() but never check their returned errors—capture and return those Close() errors to avoid hiding I/O failures when writing the tarball.
- os.MkdirTemp is invoked with "." which creates temp dirs in the repo root—pass an empty string ("" as the first arg) to use the system temp directory and avoid polluting your working tree.
- TufMirrorFS buffers the entire gzipped tar in memory before returning—consider streaming to a file or using an io.Pipe to reduce peak memory usage for large repositories.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
SequeI
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add end-to-end test and supporting utilities for installing a serialized TUF root with the policy-controller-operator
New Features:
Build:
Tests: