feat: invert cli-stack build flow using pipeline wait mechanism - #391
Open
sampras343 wants to merge 8 commits into
Open
feat: invert cli-stack build flow using pipeline wait mechanism#391sampras343 wants to merge 8 commits into
sampras343 wants to merge 8 commits into
Conversation
Invert the dependency between fetch-tsa-certs and its cli-stack so the cli-stack builds first and the component image extracts binaries from it, eliminating Konflux nudges between the two. Since CGO_ENABLED=0 across all targets, the cli-stack cross-compiles all 7 binaries (4 Linux arches + darwin + windows) from a single amd64 builder. The component Dockerfile uses the existing wait-for-pipelinerun task to receive the cli-stack digest as a build arg, then extracts the correct arch binary via TARGETARCH. SECURESIGN-4992
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch-tsa-certsandfetch-tsa-certs-cli-stackso the cli-stack builds first and the component image extracts binaries from itwait-for-pipelineruntask (same pattern as operator-bundle builds)CGO_ENABLED=0across all Build.mak targets, the cli-stack cross-compiles all 7 binaries from a single amd64 builderHow it works
fetch-tsa-certspipeline usesmanager-pipelinerun-selectorto wait forfetch-tsa-certs-cli-stackto completeCLI_STACK_IMAGEbuild arg into the component DockerfileTARGETARCHChanges
Build.makall-platformsmeta-targetDockerfile.cli-stack.rhDockerfile.fetch_tsa_certs.rhTARGETARCH(no source compilation).tekton/*-cli-stack-*.yaml.tekton/fetch-tsa-certs-*.yamlmanager-pipelinerun-selectorto wait for cli-stack; removego_unit_test,prefetch-inputRisk
FROM --platform=linux/amd64 ${CLI_STACK_IMAGE}on non-amd64 builders — Buildah may reject cross-platform FROM. If so, fallback to auto-merge nudge pattern.Related
wait-for-pipelineruntask fromsecuresign/pipelines(same mechanism as operator-bundle builds)pipelinesrepo: removebuild-nudges-reffromfetch-tsacomponent configTest plan
FROM --platform=linux/amd64pattern works on arm64/ppc64le/s390x builders