Skip to content

refactor: ♻️ match template-website copier and justfile setup #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

martonvago
Copy link
Contributor

@martonvago martonvago commented Aug 12, 2025

Description

This PR matches the copier and justfile setup in template-website.

  • copier variables renamed and reordered
  • hosting_provider variable added
  • uses realpath
  • template test moved to own file

Closes #119

This PR needs an in-depth review.

Checklist

  • Added or updated tests
  • Updated documentation
  • Ran just run-all

Comment on lines +80 to +81
# Checks and builds -----
# just run-all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to run all recipes?

  • Many checks/tests need dependencies installed (so can't skip tasks)
  • Test coverage will fail (because the repo is empty) and fail the whole test. Maybe there's a way of ignoring this?

copier.yaml Outdated
github_repo:
type: str
default: "{{ _copier_conf.dst_path | realpath | basename }}"
when: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this, like in template-website

@martonvago martonvago moved this from Todo to In Review in Iteration planning Aug 12, 2025
@martonvago martonvago marked this pull request as ready for review August 12, 2025 09:56
@martonvago martonvago requested a review from a team as a code owner August 12, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Convert build-website.yml in template to use either 'gh-pages' or 'netlify'
1 participant