Bump deps to LightInject 7.1.0 and fix AnyKey keyed service spec compliance - #221
Merged
Conversation
…liance - Update LightInject to 7.1.0 and Microsoft.Extensions.* packages to 10.0.x - Throw InvalidOperationException when GetKeyedService/GetRequiredKeyedService is called with KeyedService.AnyKey for non-enumerable types - Cache IEnumerable<T> results for AnyKey queries so repeated calls return the same instance (Assert.Same compliance) - All 266 tests pass (was 258 with 7.0.2, 8 remaining failures now resolved) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Aligns with global.json which pins 10.0.201. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Allows the CI runner's 10.0.300 SDK to satisfy the 10.0.201 version requirement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Projects target net8.0 so the workflow should use 8.0.x. The global.json was a local dev artifact and should not be in the repo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uses the multiline dotnet-version format to install both SDKs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InvalidOperationExceptionwhenGetKeyedService/GetRequiredKeyedServiceis called withKeyedService.AnyKeyfor non-enumerable types, as required by the MS DI specIEnumerable<T>results for AnyKey queries so repeated calls to the same provider return the same instance (Assert.Samecompliance)Test plan
🤖 Generated with Claude Code