Skip to content

Update plugin for breaking change in analytics-swift 1.9.1 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
+6 −6
Merged

Update plugin for breaking change in analytics-swift 1.9.1 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
359c189
Update analytics-swift to 1.9.1
sothebys-valdi Nov 7, 2025
67dd581
Update JSON.setValue call sites
sothebys-valdi Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ let package = Package(
dependencies: [
// Dependencies declare other packages that this package depends on.
// .package(url: /* package url */, from: "1.0.0"),
.package(url: "https://github.com/segmentio/analytics-swift.git", from: "1.6.0")
.package(url: "https://github.com/segmentio/analytics-swift.git", from: "1.9.1")
],
targets: [
// Targets are the basic building blocks of a package. A target can define a module or a test suite.
Expand Down
6 changes: 3 additions & 3 deletions Sources/SegmentAmplitude/AmplitudeSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public class AmplitudeSession: EventPlugin, iOSLifecycle {
if adjustedProps == nil {
adjustedProps = try? JSON(["name": screenName])
} else {
adjustedProps?.setValue(screenName, forKeyPath: KeyPath("name"))
adjustedProps?.setValue(screenName, forKeyPath: JSONKeyPath("name"))
}
screenEvent.properties = adjustedProps
workingEvent = screenEvent as? T
Expand All @@ -132,7 +132,7 @@ public class AmplitudeSession: EventPlugin, iOSLifecycle {
// if it's amp specific stuff, disable all the integrations except for amp.
if eventName.contains(Constants.ampPrefix) || eventName == Constants.ampSessionStartEvent || eventName == Constants.ampSessionEndEvent {
var integrations = disableAllIntegrations(integrations: trackEvent.integrations)
integrations?.setValue(["session_id": eventSessionID], forKeyPath: KeyPath(key))
integrations?.setValue(["session_id": eventSessionID], forKeyPath: JSONKeyPath(key))
trackEvent.integrations = integrations
}

Expand Down Expand Up @@ -186,7 +186,7 @@ extension AmplitudeSession {
var result = integrations
if let keys = integrations?.dictionaryValue?.keys {
for key in keys {
result?.setValue(false, forKeyPath: KeyPath(key))
result?.setValue(false, forKeyPath: JSONKeyPath(key))
}
}
return result
Expand Down