Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser] [GA4] Convert Consent Values to Lower Case #2535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Oct 25, 2024

This PR adds dropdown for the Ads Storage Consent State and Analytics Storage Consent State mapping, to keep it consistent with other privacy mappings, and also to send the privacy setting (denied, granted) in all lower case as that is required by google.
It also converts the privacy mapping value to lowercase to keep it compatible for users who were using GRANTED in all caps.

JIRA -> STRATCONN-4266

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

Testing successfully completed in staging via Tag Assistant.

Stage Testing Document

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.18%. Comparing base (811d006) to head (ed03ee9).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2535       +/-   ##
===========================================
- Coverage   78.51%   33.18%   -45.33%     
===========================================
  Files        1044       14     -1030     
  Lines       20029      693    -19336     
  Branches     3988      115     -3873     
===========================================
- Hits        15726      230    -15496     
+ Misses       3209      463     -2746     
+ Partials     1094        0     -1094     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AnkitSegment AnkitSegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsh-joshi99 , Changes and testing screenshots look good to me!
but lets ensure backwards compatibility, some existing destinations have values like $.properties.ads_storage_consent_state, as well as GRANTED in upper case.

Could you just do a round of testing by adding these values?

@harsh-joshi99
Copy link
Contributor Author

@harsh-joshi99 , Changes and testing screenshots look good to me! but lets ensure backwards compatibility, some existing destinations have values like $.properties.ads_storage_consent_state, as well as GRANTED in upper case.

Could you just do a round of testing by adding these values?

Tested by adding "GRANTED" in the mapping value. GA4 will ignore the all caps value, and the consent will remain unchanged. So the existing destinations that have the value in anything other that all lower caps will have to update it.

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review October 30, 2024 03:17
@harsh-joshi99 harsh-joshi99 requested review from a team as code owners October 30, 2024 03:17
@rvadera12
Copy link
Contributor

@harsh-joshi99 , Changes and testing screenshots look good to me! but lets ensure backwards compatibility, some existing destinations have values like $.properties.ads_storage_consent_state, as well as GRANTED in upper case.
Could you just do a round of testing by adding these values?

Tested by adding "GRANTED" in the mapping value. GA4 will ignore the all caps value, and the consent will remain unchanged. So the existing destinations that have the value in anything other that all lower caps will have to update it.

Do we need to do any customer communication here?

CC: @smultani

rvadera12
rvadera12 previously approved these changes Nov 5, 2024
@harsh-joshi99 harsh-joshi99 changed the title [Browser] [GA4] Add dropdown for all privacy mappings [Browser] [GA4] Convert Consent Values to Lower Case Nov 8, 2024
Copy link
Contributor

@AnkitSegment AnkitSegment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants