Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iterable] - dataField type bug #2588

Closed
wants to merge 1 commit into from
Closed

Conversation

joe-ayoub-segment
Copy link
Contributor

Fix which converts dataField values back to booleans or numbers.

This is to work around the stringification of key:value object fields as they are passed to the back end.

Testing

Unit test added.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (2ef6a2c) to head (066499f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/src/destinations/iterable/trackPurchase/index.ts 33.33% 0 Missing and 2 partials ⚠️
...ions/src/destinations/iterable/trackEvent/index.ts 50.00% 0 Missing and 1 partial ⚠️
...ions/src/destinations/iterable/updateUser/index.ts 50.00% 0 Missing and 1 partial ⚠️
...ination-actions/src/destinations/iterable/utils.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2588   +/-   ##
=======================================
  Coverage   78.54%   78.55%           
=======================================
  Files        1024     1024           
  Lines       18069    18074    +5     
  Branches     3409     3410    +1     
=======================================
+ Hits        14193    14198    +5     
  Misses       2742     2742           
  Partials     1134     1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants