[wip dont review] SFMC Create a data extension

packages/cli/src/commands/generate/types.ts

@@ -142,8 +142,7 @@ export default class GenerateTypes extends Command {
 
       if (action.hooks) {
         const hooks: ActionHookDefinition<any, any, any, any, any> = action.hooks
-        let hookBundle = ''
-        const hookFields: Record<string, any> = {}
+
         for (const [hookName, hook] of Object.entries(hooks)) {
           if (!hookTypeStrings.includes(hookName as ActionHookType)) {
             throw new Error(`Hook name ${hookName} is not a valid ActionHookType`)
@@ -155,30 +154,16 @@ export default class GenerateTypes extends Command {
             continue
           }
 
-          const hookSchema = {
-            type: 'object',
-            required: true,
-            properties: {
-              inputs: {
-                label: `${hookName} hook inputs`,
-                type: 'object',
-                properties: inputs
-              },
-              outputs: {
-                label: `${hookName} hook outputs`,
-                type: 'object',
-                properties: outputs
-              }
-            }
+          if (inputs) {
+            const inputTypes = await generateTypes(inputs, `${hookName}Inputs`)
+            types += inputTypes
+          }
+
+          if (outputs) {
+            const outputTypes = await generateTypes(outputs, `${hookName}Outputs`)
+            types += outputTypes
           }
-          hookFields[hookName] = hookSchema
         }
-        hookBundle = await generateTypes(
-          hookFields,
-          'HookBundle',
-          `// Generated bundle for hooks. DO NOT MODIFY IT BY HAND.`
-        )
-        types += hookBundle
       }
 
       if (fs.pathExistsSync(path.join(parentDir, `${slug}`))) {

packages/cli/src/lib/server.ts

@@ -259,7 +259,7 @@ function setupRoutes(def: DestinationDefinition | null): void {
     '/refreshAccessToken',
     asyncHandler(async (req: express.Request, res: express.Response) => {
       try {
-        const settings = {}
+        const settings = req.body.settings || {}
         const data = await destination.refreshAccessToken(settings, req.body)
         res.status(200).json({ ok: true, data })
       } catch (e) {
@@ -334,8 +334,10 @@ function setupRoutes(def: DestinationDefinition | null): void {
                 payload: req.body.payload || {},
                 page: req.body.page || 1,
                 auth: req.body.auth || {},
-                audienceSettings: req.body.audienceSettings || {}
+                audienceSettings: req.body.audienceSettings || {},
+                dynamicFieldContext: req.body.dynamicFieldContext || {}
               }
+
               const action = destination.actions[actionSlug]
               const result = await action.executeDynamicField(field, data)
 
@@ -404,8 +406,10 @@ function setupRoutes(def: DestinationDefinition | null): void {
                   page: req.body.page || 1,
                   auth: req.body.auth || {},
                   audienceSettings: req.body.audienceSettings || {},
-                  hookInputs: req.body.hookInputs || {}
+                  hookInputs: req.body.hookInputs || {},
+                  dynamicFieldContext: req.body.dynamicFieldContext || {}
                 }
+
                 const action = destination.actions[actionSlug]
                 const dynamicFn = dynamicInputs[fieldKey] as RequestFn<any, any, any, any>
                 const result = await action.executeDynamicField(fieldKey, data, dynamicFn)

packages/core/src/destination-kit/action.ts

@@ -73,13 +73,6 @@ export interface BaseActionDefinition {
 type HookValueTypes = string | boolean | number | Array<string | boolean | number>
 type GenericActionHookValues = Record<string, HookValueTypes>
 
-type GenericActionHookBundle = {
-  [K in ActionHookType]?: {
-    inputs?: GenericActionHookValues
-    outputs?: GenericActionHookValues
-  }
-}
-
 // Utility type to check if T is an array
 type IsArray<T> = T extends (infer U)[] ? U : never
 
@@ -94,7 +87,9 @@ export interface ActionDefinition<
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   AudienceSettings = any,
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  GeneratedActionHookBundle extends GenericActionHookBundle = any
+  GeneratedActionHookInputs = any,
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  GeneratedActionHookOutputs = any
 > extends BaseActionDefinition {
   /**
    * A way to "register" dynamic fields.
@@ -139,8 +134,8 @@ export interface ActionDefinition<
       Settings,
       Payload,
       AudienceSettings,
-      NonNullable<GeneratedActionHookBundle[K]>['outputs'],
-      NonNullable<GeneratedActionHookBundle[K]>['inputs']
+      NonNullable<GeneratedActionHookInputs>,
+      NonNullable<GeneratedActionHookOutputs>
     >
   }
 
@@ -170,8 +165,8 @@ export interface ActionHookDefinition<
   Settings,
   Payload,
   AudienceSettings,
-  GeneratedActionHookOutputs,
-  GeneratedActionHookTypesInputs
+  GeneratedActionHookTypesInputs,
+  GeneratedActionHookOutputs
 > {
   /** The display title for this hook. */
   label: string

packages/core/src/destination-kit/types.ts

@@ -36,6 +36,8 @@ export interface DynamicFieldContext {
   selectedArrayIndex?: number
   /** The key within a dynamic object for which we are requesting values */
   selectedKey?: string
+  /** The RichInput dropdown search query the user has entered */
+  query?: string
 }
 
 export interface ExecuteInput<

packages/destination-actions/src/destinations/linkedin-conversions/api/api.test.ts

@@ -2,15 +2,15 @@ import nock from 'nock'
 import createRequestClient from '../../../../../core/src/create-request-client'
 import { LinkedInConversions } from '../api'
 import { BASE_URL } from '../constants'
-import { HookBundle } from '../streamConversion/generated-types'
+import { OnMappingSaveInputs, OnMappingSaveOutputs } from '../streamConversion/generated-types'
 
 const requestClient = createRequestClient()
 
 describe('LinkedIn Conversions', () => {
   describe('conversionRule methods', () => {
     const linkedIn: LinkedInConversions = new LinkedInConversions(requestClient)
     const adAccountId = 'urn:li:sponsoredAccount:123456'
-    const hookInputs: HookBundle['onMappingSave']['inputs'] = {
+    const hookInputs: OnMappingSaveInputs = {
       adAccountId,
       name: 'A different name that should trigger an update',
       conversionType: 'PURCHASE',
@@ -19,7 +19,7 @@ describe('LinkedIn Conversions', () => {
       view_through_attribution_window_size: 7
     }
 
-    const hookOutputs: HookBundle['onMappingSave']['outputs'] = {
+    const hookOutputs: OnMappingSaveOutputs = {
       id: '56789',
       name: 'The original name',
       conversionType: 'LEAD',