Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsys Audiences #2739

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Responsys Audiences #2739

wants to merge 11 commits into from

Conversation

seg-leonelsanches
Copy link
Contributor

This is the same implementation done in #2398, but dedicated to Engage.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Responsys Audiences, Settings:baseUrl,username,userPassword,insertOnNoMatch,updateOnMatch,matchColumnName1
  • Destination: Responsys Audiences, Action:syncAudience, Fields:recipientData,computation_key,traits_or_props
  • Destination: Responsys (Actions), Action Field(s):recipientData,computation_key,traits_or_props

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 84.49198% with 29 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@078cbaa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ions/src/destinations/responsys-audiences/index.ts 61.53% 9 Missing and 6 partials ⚠️
.../src/destinations/responsys-audiences/functions.ts 80.48% 6 Missing and 2 partials ⚠️
...ions/responsys-audiences/syncAudience/functions.ts 94.38% 0 Missing and 5 partials ⚠️
...inations/responsys-audiences/syncAudience/index.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2739   +/-   ##
=======================================
  Coverage        ?   78.55%           
=======================================
  Files           ?     1040           
  Lines           ?    18982           
  Branches        ?     3603           
=======================================
  Hits            ?    14911           
  Misses          ?     2853           
  Partials        ?     1218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant