[Dot Digital] new Destination

[joe-ayoub-segment]

New Cloud Mode Destination for Dot Digital

Code copied and edited from original Partner PR here: #2871

Testing

TBC

[github-actions]

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

• Destination: Dotdigital, Settings:api_host,username,password
• Destination: Dotdigital, Action:removeContactFromList, Fields:channelIdentifier,emailIdentifier,mobileNumberIdentifier,listId
• Destination: Dotdigital, Action:enrolContact, Fields:channelIdentifier,emailIdentifier,mobileNumberIdentifier,programId
• Destination: Dotdigital, Action:addContactToList, Fields:channelIdentifier,emailIdentifier,mobileNumberIdentifier,listId

Add these new fields as optional instead and assume default values in perform or performBatch block.

[codecov]

Codecov Report

Attention: Patch coverage is 51.08696% with 90 lines in your changes missing coverage. Please review.

Project coverage is 77.82%. Comparing base (90998c5) to head (cada789).
Report is 27 commits behind head on main.

Files with missing lines	Patch %	Lines
...ions/dotdigital/api/resources/dd-datafields-api.ts	8.77%	51 Missing and 1 partial ⚠️
...tinations/dotdigital/api/resources/dd-lists-api.ts	18.18%	18 Missing ⚠️
...tions/dotdigital/api/resources/dd-enrolment-api.ts	46.66%	8 Missing ⚠️
.../src/destinations/dotdigital/enrolContact/index.ts	68.42%	4 Missing and 2 partials ⚠️
...-actions/src/destinations/dotdigital/api/dd-api.ts	72.72%	2 Missing and 1 partial ⚠️
.../destinations/dotdigital/addContactToList/index.ts	80.00%	2 Missing ⚠️
...inations/dotdigital/removeContactFromList/index.ts	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
- Coverage   78.11%   77.82%   -0.29%     
==========================================
  Files        1050     1077      +27     
  Lines       19438    19796     +358     
  Branches     3734     3792      +58     
==========================================
+ Hits        15184    15407     +223     
- Misses       2972     3101     +129     
- Partials     1282     1288       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[joe-ayoub-segment]

hi @sta1r I've updated the code. I didn't need to change any tests. Please take a look and let me know if it looks good to you!
Next deploy is Tuesday.

[sta1r]

@joe-ayoub-segment All looks good to me. If we can just squeeze in the amend to the overall description text per the comment, that would perfect. Otherwise good to go for Tuesday.

[joe-ayoub-segment]

hi @sta1r PR deployed. I'll send instructions by email.