Fix session start data issue #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d37d2d3.
MichaelGHSeg
approved these changes
Jan 27, 2025
wenxi-zeng
reviewed
Jan 27, 2025
| val defaultSettings = configuration.defaultSettings ?: Settings( | ||
| integrations = buildJsonObject { | ||
| put( | ||
| "Segment.io", |
There was a problem hiding this comment.
maybe better to make this a constant in SegmentDestination and reference it here?
There was a problem hiding this comment.
I think we can add constructors in Settings so it's consistent with swift's implementation and that forces every settings created to have a segment destination
There was a problem hiding this comment.
Yeah, I agree, there are too many differences :( from swift.
wenxi-zeng
reviewed
Jan 27, 2025
| @@ -89,7 +89,7 @@ abstract class DestinationPlugin : EventPlugin { | |||
| override val type: Plugin.Type = Plugin.Type.Destination | |||
| private val timeline: Timeline = Timeline() | |||
| override lateinit var analytics: Analytics | |||
| internal var enabled = false | |||
| internal var enabled = true | |||
There was a problem hiding this comment.
👍 good catch! otherwise we might have issue when the user first opens the app offline and plugins are disabled by default.
wenxi-zeng
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We identified an issue with data loss that would occur when the host app would startup with no internet connection.
In these circumstances the SDK would not be able to download a valid Settings object and would not use either a good default or fallback to the previous known good Settings object.
This fix address various issues that lead to dataloss:
nullinstead of an empty Settings object (parity with analytics-swit)trueinstead offalse(parity with intention of analytics-swift)Note: This PR contains a revert of a previous commit that set Configuration.settings object to an empty Settings object, so there are many changes related to the tests.