Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemotePlugins typescript type #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Apr 16, 2024

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 62d4056

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky marked this pull request as ready for review April 16, 2024 17:13
@silesky silesky requested a review from chrisradek April 16, 2024 17:13
@silesky silesky changed the title fix TS type fix RemotePlugins typescript type Apr 16, 2024
@silesky silesky changed the title fix RemotePlugins typescript type Fix RemotePlugins typescript type Apr 16, 2024
@chrisradek
Copy link
Contributor

Ah, I guess we could view this as a breaking change if someone were passing in their own CDN settings (seems unlikely outside of tests though)

@silesky
Copy link
Contributor Author

silesky commented Apr 16, 2024

Ah, I guess we could view this as a breaking change if someone were passing in their own CDN settings (seems unlikely outside of tests though)

Microsoft/Typescript philosophy? Types are never breaking changes :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants