Skip to content

Replaced getApplicationDocumentsDirectory() with getApplicationSupportDirectory in io.dart #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2025
Merged

Replaced getApplicationDocumentsDirectory() with getApplicationSupportDirectory in io.dart #181

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06d06da
Replaced getApplicationDocumentsDirectory() with getApplicationSuppor…
neelkanth-kaushik Sep 16, 2025
bddb860
Migrating JSON files from old directory to new location
neelkanth-kaushik Sep 22, 2025
f78df86
Fixed LIBRARIES-2791
neelkanth-kaushik Sep 23, 2025
b88cf8e
Fixed LIBRARIES-2791
neelkanth-kaushik Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/lib/utils/store/io.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class StoreImpl with Store {

Future<Directory> _getDocumentDir() async {
try {
return await getApplicationDocumentsDirectory();
return await getApplicationSupportDirectory();
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change modifies where application data is stored, which could be a breaking change for existing users. Consider implementing a migration strategy to move existing data from the documents directory to the application support directory, or provide a configuration option to maintain backward compatibility.

Suggested change
return await getApplicationSupportDirectory();
final newDir = await getApplicationSupportDirectory();
final oldDir = await getApplicationDocumentsDirectory();
// Migrate old files if they exist
final oldFiles = oldDir
.listSync()
.whereType<File>()
.where((file) => file.path.contains('analytics-flutter-') && file.path.endsWith('.json'));
for (final oldFile in oldFiles) {
final fileName = oldFile.uri.pathSegments.last;
final newFile = File('${newDir.path}/$fileName');
if (!await newFile.exists()) {
await oldFile.copy(newFile.path);
await oldFile.delete();
}
}
return newDir;

Copilot uses AI. Check for mistakes.

} catch (err) {
throw PlatformNotSupportedError();
}
Expand Down