Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding warning to Warehouse Selective Sync section #4772

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

pmbasco
Copy link
Contributor

@pmbasco pmbasco commented May 22, 2023

Proposed changes

Customers have reached out regarding failed warehouse syncs and after taking the proper troubleshooting steps we determine that the error is caused by the customer disabling the received_at property in one or many of their collections in their Warehouse Selective sync settings.

I think adding a warning that states that we use received_at as the sort key for all tables and that disabling this column will cause syncs to fail would be beneficial as it would avoid any failures / disruption in data flow.

Merge timing

  • ASAP once approved

@pmbasco pmbasco added the KCS label May 22, 2023
@jacobwsmith19 jacobwsmith19 marked this pull request as ready for review August 21, 2023 15:46
@forstisabella
Copy link
Contributor

Hi @pmbasco, @jacobwsmith19 - is there a permanent loss of data associated with a failed sync, or are you all able to recover the missing data with a backfill? If there's a potential for permanent data loss, I would recommend using the error callout instead of the warning callout!

@forstisabella forstisabella merged commit 965b2b7 into develop Sep 7, 2023
@forstisabella forstisabella deleted the pmbasco-patch-3 branch September 7, 2023 23:14
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants