Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1Flow iOS doc update #5322

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

rohantryskybox
Copy link
Contributor

Proposed changes

Merge timing

Related issues (optional)

@rohantryskybox rohantryskybox requested a review from a team as a code owner September 11, 2023 11:01
@rohantryskybox rohantryskybox requested review from forstisabella and removed request for a team September 11, 2023 11:01
@tcgilbert tcgilbert self-requested a review September 11, 2023 13:52
2. Find the Destinations Actions item in the left navigation, and click it.
3. Click **Configure 1Flow**.
4. Select an existing Source to connect to 1Flow (Actions).
5. Copy 1Flow project key and paste it into the Connection Settings in Segment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rohantryskybox - where could a user find the 1Flow project key? Could we add a step or two here explaining how you could find the key in 1Flow?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,50 @@
---
title: 1Flow (Actions) Destination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 1Flow (Actions) Destination
title: 1Flow Mobile Plugin Destination
id: 64dd07c1fed86b6866cd93f5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for suggestion

Comment on lines 13 to 17
1. From the Segment web app, click **Catalog**, then click **1Flow**.
2. Find the Destinations Actions item in the left navigation, and click it.
3. Click **Configure 1Flow**.
4. Select an existing Source to connect to 1Flow (Actions).
5. Go to 1flow.ai -> Settings -> Project Settings -> Copy 1Flow project key and paste it into the Connection Settings in Segment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. From the Segment web app, click **Catalog**, then click **1Flow**.
2. Find the Destinations Actions item in the left navigation, and click it.
3. Click **Configure 1Flow**.
4. Select an existing Source to connect to 1Flow (Actions).
5. Go to 1flow.ai -> Settings -> Project Settings -> Copy 1Flow project key and paste it into the Connection Settings in Segment.
1. From the Segment web app, click **Catalog**, then search for **1Flow Mobile Plugin**.
2. Click **Add Destination**.
4. Select an existing Source to connect to 1Flow Mobile Plugin.
5. Go to 1flow.ai -> Settings -> Project Settings, copy the 1Flow project key, and paste it into the Destination Settings in Segment.
6. Depending on the mobile source you’ve selected, include 1Flow's library by adding the following lines to your dependency configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

3. Click **Configure 1Flow**.
4. Select an existing Source to connect to 1Flow (Actions).
5. Go to 1flow.ai -> Settings -> Project Settings -> Copy 1Flow project key and paste it into the Connection Settings in Segment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add installation instructions for each library, see example documentation here:

Suggested change
### iOS
1. Add the 1Flow Segment Pod to your `Podfile`:
```
pod '1Flow-Segment'
```
(add other relevant instructions)
### Android
1. In the top-level project `build.gradle` add the following as a repository in *all projects > repositories*.
```js
maven { url "http://appboy.github.io/1flow-android-sdk/sdk" }
maven { url "http://appboy.github.io/1flow-segment-android/sdk" }
```
(add other relevant instructions)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Also added setup instructions

title: 1Flow Mobile Plugin Destination
---

[1Flow](https://1flow.ai/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners) is a leading in-app user survey and messaging platform for Mobile app and SaaS businesses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[1Flow](https://1flow.ai/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners) is a leading in-app user survey and messaging platform for Mobile app and SaaS businesses.
[1Flow](https://1flow.ai/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners){:target="_blank"} is a leading in-app user survey and messaging platform for Mobile app and SaaS businesses.

Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and g2g pending two comments!

@rohan1flow
Copy link

Approved and g2g pending two comments!

Addressed both. Ready if you want to take a look

@forstisabella
Copy link
Contributor

lgtm! I'll wait for one more review from @tcgilbert before we merge

@forstisabella forstisabella merged commit 097e6f0 into segmentio:develop Sep 14, 2023
@github-actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants