Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accoil Analytics destination action documentation #7047

Merged

Conversation

accoilmj
Copy link
Contributor

@accoilmj accoilmj commented Sep 19, 2024

Proposed changes

This is documentation for the new Accoil Analytics Segment Destination Action which is currently privately available for installation and soon to have its first test customer.

Merge timing

Happy for this to merge whenever ready as a beta doc and can raise a separate PR later to remove that.

Related issues (optional)

Action merged on segmentio/action-destinations#2421

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit a2edd13
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/66fdcf8c8cd2140008609fc2
😎 Deploy Preview https://deploy-preview-7047--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@accoilmj accoilmj marked this pull request as ready for review September 30, 2024 00:51
@accoilmj accoilmj requested a review from a team as a code owner September 30, 2024 00:51
@forstisabella forstisabella added the new-integration Added a new source or destination label Sep 30, 2024
@accoilmj
Copy link
Contributor Author

accoilmj commented Oct 1, 2024

Thanks for your review @forstisabella . I've applied your suggested changes.

forstisabella
forstisabella previously approved these changes Oct 1, 2024
@accoilmj
Copy link
Contributor Author

accoilmj commented Oct 1, 2024

Thanks again @forstisabella . I've applied that last suggestion 👍 Let me know if there's anything I need to do on my end to progress forward.

@forstisabella
Copy link
Contributor

hi @accoilmj - we're waiting on approval from @tcgilbert on this PR before we merge. Thanks for being on top of this!

forstisabella
forstisabella previously approved these changes Oct 2, 2024
Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few of changes

@accoilmj
Copy link
Contributor Author

accoilmj commented Oct 3, 2024

Thanks @tcgilbert ! I've applied those suggested changes now.

@forstisabella forstisabella merged commit 3d7f777 into segmentio:develop Oct 3, 2024
4 checks passed
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-integration Added a new source or destination
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants