Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retl bq docs #7134

Merged
merged 38 commits into from
Oct 15, 2024
Merged

Update retl bq docs #7134

merged 38 commits into from
Oct 15, 2024

Conversation

gilsegment
Copy link
Contributor

@gilsegment gilsegment commented Oct 10, 2024 •
edited
Loading

Ticket

https://segment.atlassian.net/browse/RETL-1617

Proposed changes

Updating Reverse-ETL BigQuery documentation. It seems that it wasn't fully up to date.

Merge timing

ASAP

Related issues (optional)

Box BigQuery permission issue

@gilsegment gilsegment requested a review from a team as a code owner October 10, 2024 16:24
@gilsegment gilsegment requested a review from pwseg October 10, 2024 16:24
@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 171fa39
🔍 Latest deploy log https://app.netlify.com/sites/segment-docs/deploys/67096443df38de000810adbd
😎 Deploy Preview https://deploy-preview-7134--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prayansh
prayansh previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions. but looks good overall!

src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
forstisabella
forstisabella reviewed Oct 10, 2024
View reviewed changes
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
gilsegment and others added 13 commits October 10, 2024 14:43
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
d52f819 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
8490ddd 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
060be82 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
f2c2bce 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
62beb23 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
018f111 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @prayansh
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
3be45e5 
…gquery-setup.md

Co-authored-by: Prayansh Srivastava <[email protected]>
@gilsegment @prayansh
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
225da70 
…gquery-setup.md

Co-authored-by: Prayansh Srivastava <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
7c22cc1 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @prayansh
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
1379da9 
…gquery-setup.md

Co-authored-by: Prayansh Srivastava <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
3f6d479 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
@gilsegment @prayansh
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
96e98bf 
…gquery-setup.md

Co-authored-by: Prayansh Srivastava <[email protected]>
@gilsegment @forstisabella
Update src/connections/reverse-etl/reverse-etl-source-setup-guides/bi…
5238b2b 
…gquery-setup.md

Co-authored-by: forstisabella <[email protected]>
gilsegment and others added 6 commits October 10, 2024 15:10
forstisabella
forstisabella reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few changes and we'll be g2g!

src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
src/connections/reverse-etl/reverse-etl-source-setup-guides/bigquery-setup.md Outdated Show resolved Hide resolved
@seg-atlantis-prod

This comment has been minimized.

Sign in to view
@seg-atlantis-prod

This comment has been minimized.

Sign in to view
@seg-atlantis-prod
Copy link

Plan Error

the default workspace at path . is currently locked by another command that is running for this pull request.
Wait until the previous command is complete and try again

@gilsegment gilsegment merged commit 083fad9 into develop Oct 15, 2024
4 of 5 checks passed
@gilsegment gilsegment deleted the updateRetlBqDocs branch October 15, 2024 18:53
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayansh prayansh prayansh left review comments

@forstisabella forstisabella forstisabella approved these changes

@pwseg pwseg Awaiting requested review from pwseg pwseg is a code owner automatically assigned from segmentio/segment-doc-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilsegment @prayansh @forstisabella @pwseg