Remove note callouts from the docs #7433
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forstisabella
added
the
back-end
forstisabella
commented
Feb 7, 2025
src/connections/destinations/catalog/actions-hubspot-cloud/index.md
Outdated
Show resolved
Hide resolved
forstisabella
commented
Feb 7, 2025
| @@ -148,8 +145,8 @@ To create an IAM role: | |||
| 7. Copy and paste the following code into your trust relationship. You should replace `<your-source-id>` with either the Source ID of the attached Segment source (the default) or the External ID set in your AWS Lambda destination settings. | |||
| * `arn:aws:iam::595280932656:role/customer-lambda-prod-destination-access` refers to Segment's AWS Account, and is what allows Segment's Destination to access the role to invoke your Lambda. | |||
|
|
|||
| > note "" | |||
| > **Note**: Source ID can be found by navigating to **Settings > API Keys** from your Segment source homepage. | |||
| > success "" | |||
There was a problem hiding this comment.
Suggested change
| > success "" | |
| > info "" |
forstisabella
commented
Feb 7, 2025
| @@ -46,10 +46,9 @@ When you send an Alias call to CleverTap, CleverTap updates the user's profile w | |||
|
|
|||
| ## Track | |||
|
|
|||
| When you `track` an event, Segment sends that event to CleverTap as a custom event. Note that CleverTap does not support arrays or nested objects for custom track event properties. | |||
| When you `track` an event, Segment sends that event to CleverTap as a custom event. CleverTap requires `identify` traits such as `userId` or `email` to record and associate the Track event. Without these traits, the Track event does not appear in CleverTap. | |||
There was a problem hiding this comment.
Suggested change
| When you `track` an event, Segment sends that event to CleverTap as a custom event. CleverTap requires `identify` traits such as `userId` or `email` to record and associate the Track event. Without these traits, the Track event does not appear in CleverTap. | |
| When you `track` an event, Segment sends that event to CleverTap as a custom event. CleverTap requires Identify traits like `userId` or `email` to record and associate the Track event. Without these traits, the Track event does not appear in CleverTap. |
forstisabella
commented
Feb 7, 2025
|
|
||
| > note "" | ||
| > CleverTap requires `identify` traits such as `userId` or `email` to record and associate the Track event. Without these traits, the Track event does not appear in CleverTap. | ||
| CleverTap does not support arrays or nested objects for custom track event properties. |
There was a problem hiding this comment.
Suggested change
| CleverTap does not support arrays or nested objects for custom track event properties. | |
| CleverTap does not support arrays or nested objects for custom Track event properties. |
forstisabella
commented
Feb 7, 2025
| > note "" | ||
| > **Note:** Segment sends traits in [Identify](/docs/connections/spec/identify) calls that map to Custom Dimensions in Google Analytics when the next [Track](/docs/connections/spec/track) or [Page call](/docs/connections/spec/page) call triggers from the browser. | ||
| > success "" | ||
| > Segment sends traits in [Identify](/docs/connections/spec/identify) calls that map to Custom Dimensions in Google Analytics when the next [Track](/docs/connections/spec/track) or [Page call](/docs/connections/spec/page) call triggers from the browser. |
There was a problem hiding this comment.
Suggested change
| > Segment sends traits in [Identify](/docs/connections/spec/identify) calls that map to Custom Dimensions in Google Analytics when the next [Track](/docs/connections/spec/track) or [Page call](/docs/connections/spec/page) call triggers from the browser. | |
| > Segment sends traits in [Identify](/docs/connections/spec/identify) calls that map to Custom Dimensions in Google Analytics when the next [Track](/docs/connections/spec/track) or [Page](/docs/connections/spec/page) call triggers from the browser. |
forstisabella
commented
Feb 7, 2025
| > note "" | ||
| > **Note**: Please make sure the name of the serviceworker file is `serviceworker.js`. Please contact MoEngage support at [email protected] if you wish to have some other name for the serviceworker file. | ||
| > info "Serviceworker file naming convention" | ||
| > The name of the serviceworker file must be `serviceworker.js`. Please contact MoEngage support at [email protected] if you want to give your serviceworker file a different filename. |
There was a problem hiding this comment.
Suggested change
| > The name of the serviceworker file must be `serviceworker.js`. Please contact MoEngage support at [email protected] if you want to give your serviceworker file a different filename. | |
| > The name of the serviceworker file must be `serviceworker.js`. Please contact MoEngage support at [email protected] if you want to give your serviceworker file a different name. |
forstisabella
commented
Feb 7, 2025
| @@ -11,7 +11,16 @@ versions: | |||
| link: /docs/connections/destinations/catalog/actions-recombee | |||
| --- | |||
|
|
|||
| <<<<<<< Updated upstream | |||
There was a problem hiding this comment.
Suggested change
| <<<<<<< Updated upstream |
forstisabella
commented
Feb 7, 2025
| [Recombee](https://recombee.com/?utm_source=segmentio&utm_medium=docs&utm_campaign=partners){:target="_blank”} is a Recommender as a Service that can use your data to provide the most accurate recommendations of content or products for your users. | ||
| ======= |
There was a problem hiding this comment.
Suggested change
| ======= |
forstisabella
commented
Feb 7, 2025
| > note "" | ||
| > In the app, data from website, mobile, and server sources can go to a warehouse **or** to destinations. Object Cloud-App Source data can **only** go to Warehouses. | ||
| > info "" | ||
| > You can send data from website, mobile, and server sources to a warehouse **or** to destinations. You can only send object cloud app source data can **only** go to warehouses. |
There was a problem hiding this comment.
Suggested change
| > You can send data from website, mobile, and server sources to a warehouse **or** to destinations. You can only send object cloud app source data can **only** go to warehouses. | |
| > You can send data from website, mobile, and server sources to a warehouse **or** to destinations. You can only send object cloud app source data to warehouses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As Mark pointed out in 2023, we probably don't need the note callouts in the docs (and the Twilio docs site doesn't have them either 👀). This PR removes all the note callouts and replaces them with the best-fitting other callout (although mostly info). + light Vale edits + removing some outdated information.
Merge timing
Whenever, as I know this is going to be a PITA to review all this (thanks in advance 🫶)
Related issues (optional)