Add new props: tag, wrapperClasses, svgClasses #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webistomin you can check vue-inline-svg it doesn't add wrapper at all. |
|
I was just about to code this. Thanks @webistomin ! What is holding back this MR @seiyable ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for your plugin.
During the development I had a problem. I needed to put the svg inside the
<button>, but the plugin automatically added adivwrapper. I think this is not quite semantic.<button>must contain only phrasing content. Phrasing content is defined as including<span>or something else but not<div>.So, I added new props for tag name. Also added props for wrapper and svg element classes to add more flexibility and functionality to plugin.