Update Android builds to use new ToyVPN #1769
Conversation
.github/workflows/build_and_test.yml
Outdated
| with: | ||
| repository: seladb/ToyVpn-PcapPlusPlus | ||
| path: ./ToyVpn-PcapPlusPlus | ||
| ref: "new-toyvpn" |
There was a problem hiding this comment.
This will be removed once this PR is approved, and the new ToyVPN is released
There was a problem hiding this comment.
Updated in this commit: b9e9672
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1769 +/- ##
========================================
Coverage 83.10% 83.10%
========================================
Files 283 283
Lines 48929 48929
Branches 10276 10520 +244
========================================
Hits 40664 40664
- Misses 7113 7125 +12
+ Partials 1152 1140 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Dimi1010 @tigercosmos @clementperon @egecetin can someone review this PR? |
.github/workflows/build_and_test.yml
Outdated
| working-directory: ./ToyVpn-PcapPlusPlus | ||
| run: ./gradlew build -PabiFilter=${{ matrix.target}} |
There was a problem hiding this comment.
this two command could be done in the same job I think
| arch: ${{ matrix.target }} | ||
| working-directory: ./ToyVpn-PcapPlusPlus | ||
| script: ./gradlew -is connectedCheck -PabiFilter=${{ matrix.target}} | ||
| # Uncomment to enable logs |
There was a problem hiding this comment.
Indents looks weird, but should be fine.
There is a new version of ToyVPN, which is a complete rewrite of the Android app using modern Android tools: https://github.com/seladb/ToyVpn-PcapPlusPlus/tree/new-toyvpn
This PR modifies PcapPlusPlus build to use the new version.
The new ToyVPN version has not yet been released. It will be released together with this PR, once approved.