heckIfValuesAreAnObject class refactored two seperate method

selamiphp · Sep 18, 2017 · 0705c83 · 0705c83
1 parent f7de6f0
commit 0705c83
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/EqualsBuilder.php b/src/EqualsBuilder.php
@@ -26,7 +26,7 @@ public function append($leftHandedValue, $rightHandedValue)
         if ($this->isEquals === false) {
             return $this;
         }
-        if ($this->checkIfValuesAreClass($leftHandedValue, $rightHandedValue)) {
+        if ($this->checkIfValuesAreAnObjectAndEqual($leftHandedValue, $rightHandedValue)) {
             return $this;
         }
         if ($this->checkForSameType($leftHandedValue, $rightHandedValue)) {
@@ -44,9 +44,9 @@ private function checkForSameType($leftHandedValue, $rightHandedValue) :bool
         return true;
     }
 
-    private function checkIfValuesAreClass($leftHandedValue, $rightHandedValue) : bool
+    private function checkIfValuesAreAnObjectAndEqual($leftHandedValue, $rightHandedValue) : bool
     {
-        if (! is_object($leftHandedValue) || ! is_object($rightHandedValue)) {
+        if (! $this->checkIfValuesAreAnObject($leftHandedValue, $rightHandedValue)) {
             return false;
         }
         if (get_class($leftHandedValue) !== get_class($rightHandedValue)) {
@@ -59,6 +59,10 @@ private function checkIfValuesAreClass($leftHandedValue, $rightHandedValue) : bo
         }
         return true;
     }
+    private function checkIfValuesAreAnObject($leftHandedValue, $rightHandedValue) : bool
+    {
+        return (is_object($leftHandedValue) && is_object($rightHandedValue));
+    }
 
     private function compareObjectProperties($leftHandedObject, $rightHandedObject) : bool
     {