This repository has been archived by the owner on Jun 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #54 a draft to show how far I got building cross platform images on Ubuntu (Ubuntu also offers arm64 images).
I replaced chrome with chromium from Debian (Ubuntu's packages are based on 'snap')
Firefox I get from the 'team mozilla' package repository (Ubuntu's own packages are based on 'snap')
I updated the GitHub action to build/test on both platforms (and removed other actions for now, as I was not interested in those yet). The arm64 test fails for this action, but passes locally on my M1 Mac. I think the issue on GitHub is the emulation that is just TOO slow, but as far as I can tell the actual images work.
I did not get fixed browser versions yet, but that should be doable by supplying a version to their
apt-get
commands.Far from finished, but the changes from the base selenium image are also quite small which might make this path easier to get to work (and maintain in the future).
The PR looks big, but compared to upstream trunk it is not so big (ignoring the GitHub actions removed for now): fhoeben@a71ea88#diff-c7235ebbda8248c044e6b13da481ae97f4a21846ed2341a056b6b873abaa482b
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist