Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds alertbox to definition pages #158

Closed
wants to merge 5 commits into from
Closed

Adds alertbox to definition pages #158

wants to merge 5 commits into from

Conversation

jlealess
Copy link
Contributor

  • creates a new alertbox component to encourage users to contribute
  • adds alertbox component to definition page template to ask users improve existing definitions

@tatianamac
Copy link
Collaborator

@jlealess ! Awesome work on this! I think we can expand this later to include the Edit on GitHub feature Oscar mentioned.

In the meantime, consider this is PR approved once you update the branch to align with the most current version.

Once this is merged in, would it be okay to thank you on Twitter?

@tatianamac tatianamac linked an issue May 27, 2020 that may be closed by this pull request
🗃️ Build "revise term" alert box #141
Open
@jlealess
Copy link
Contributor Author

@tatianamac I'm updating the branch to align with the most current version of master today, but I'm seeing a merge conflict; does this alert box go before or after the content warning that's been added to the definition template?

And yes, you can thank me on Twitter; thank you for helping me through this!

@tatianamac
Copy link
Collaborator

Good question. I think below for now is good. Long term the larger, bottom content warning box is going to go away. The top content warning will lead you to another page, I think.

@tatianamac tatianamac closed this Jun 5, 2020
@tatianamac
Copy link
Collaborator

@jlealess Do you mind opening a new PR? Unfortunately when I renamed the branch it force closes all the open PRs. Thank you!

@tatianamac tatianamac added the Status · Needs Submitter Info Requires more information from submitter before proceeding label Jun 10, 2020
@jlealess jlealess mentioned this pull request Jun 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatianamac tatianamac tatianamac approved these changes

Assignees
No one assigned
Labels
Status · Needs Submitter Info Requires more information from submitter before proceeding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🗃️ Build "revise term" alert box
2 participants
@jlealess @tatianamac