-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Frequently Asked Questions (FAQs) Page (Issue #246) #288
Initial Frequently Asked Questions (FAQs) Page (Issue #246) #288
Conversation
… Documentation page and cross-linked accordingly. Corresponds to issue selfdefined#246
… Contributing Guidelines docs. Corresponds to issue selfdefined#246
…this commit adds `Get Help` back
@mannybecerra Excellent work! I provided some prescriptive edits using the suggestions functionality. Please take a look and let me know if I can clarify anything. As for other questions, I think it'd be great to collect some questions from folks in the Slack community and I can start to answer them. Would you be willing to lead that? |
@mannybecerra I would prefer the latter, personally. |
@tatianamac sweet. I just saw your other comment about the prescriptive edits before I posted my original linting question to you. After seeing it, I was just going to move my question to your other question's thread to keep it all intact but now I just created a whirlwind. I'll update the FAQs content to leverage Regarding |
…per feedback from Tatiana
Feedback from Tatiana Co-authored-by: Tatiana Mac <[email protected]>
Copy feedback from Tatiana Co-authored-by: Tatiana Mac <[email protected]>
I trust you to take whatever approach makes the most sense with this. Mostly, I think there are valuable insights from the community built there. I think it could empower folks who have found our documentation confusing or unclear to get started. Re: edits: Sounds perfect! Thank you again! |
Great @tatianamac , thanks. I am hitting a snag with with the FAQ page and converting the content to use |
…plate since we're utilizing dl, dt & dd markup tags for our FAQ content. Changes include corresponding CSS rules for dl and dt tags and minor punctuation update in the contributing guidelines. Addresses issue selfdefined#246
…-frequently-asked-questions
I agree @tatianamac . Done e793749 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM!
@mannybecerra I'll merge in this PR and if you'd like to work further on questions, we can collect those for a new PR. |
Suena bien @tatianamac ! |
Hey Team,
This is the initial creation of the requested Frequently Asked Questions (FAQs) page for issue #246.
Summary
Documentation
page and linked to accordingly./documentation/frequently-asked-questions
(relative to the app's root)Notes:
dl
,dt
&dd
markup tags for the FAQ content. Context can be found in our Slack channel here and over hereIf changes are desired before merging this PR, I'm on standby to review and implement any requests.
Gracias 🙌🏼
UI Screenshots
Lighthouse results (on local environment)
New FAQs Page
Updated Documentation Page
Updated Contributing Guidelines Doc