-
-
Notifications
You must be signed in to change notification settings - Fork 61
[MAJOR] Next-generation web interface and direct WebSocket support #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ehfd
wants to merge
122
commits into
main
Choose a base branch
from
feature/websockets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+30,321
−4,811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be feature complete
…de, establish messaging bus for websockets mode, add dumping and sending of system stats for websockets, add mode change logic to change settings on the fly
…isconfigured servers
…io pipelines, change behavior so when the page is hidden we stop the video pipeline but keep audio running if it is
…terposer to match, expand the defs used for the input mapping to be in sync with a real 360 controller
…4 endpoints and modify how shared mode works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference the issue numbers and reviewers
Responsible: @ehfd @thelamer @PMohanJ
Main Issue aiming to solve:
Issues and PRs to be solved (only close when this PR has been merged and code is present in
main
, not before that):Web/Interface:
Code quality and performance:
system_metrics.py
has a lot of things to be optimized usingasyncio
coroutines instead of the large blocks of for loops.asyncio
coroutines rigorously across the whole backend code.start_ws_pipeline
andbuild_webrtcbin_pipeline
, etc. ingstreamer_pipeline.py
, most of these can be merged.argparse
options. Hard-coding is discouraged.selkies-gstreamer-resize = "selkies_gstreamer.resize:entrypoint"
inpyproject.toml
.Input:
WebRTC:
Media:
CI/CD or Maintenance:
selkies-gstreamer
references toselkies
)Divide Dockerfile to various containers in selkies-vdi #161 (optional, follow up in another PR)Explain relevant issues and how this pull request solves them
New updated web interface and direct WebSocket support, with other improvements.
Describe the changes in code and its dependencies and justify that they work as intended after testing
New updated web interface and direct WebSocket support, with countless other improvements.