feat: require Node.js 8.3

BREAKING CHANGE: remove support for Node.js < 8.3
semantic-release · Jun 6, 2019 · 542be77 · 542be77
1 parent f49ac93
commit 542be77
Show file tree

Hide file tree

Showing 21 changed files with 136 additions and 173 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,9 +1,9 @@
 language: node_js
 
 node_js:
+  - 12
   - 10
   - 8
-  - 6
 
 branches:
   only:

diff --git a/index.js b/index.js
@@ -31,9 +31,9 @@ const services = {
 module.exports = ({env = process.env, cwd = process.cwd()} = {}) => {
 	for (const name of Object.keys(services)) {
 		if (services[name].detect({env, cwd})) {
-			return Object.assign({isCi: true}, services[name].configuration({env, cwd}));
+			return {isCi: true, ...services[name].configuration({env, cwd})};
 		}
 	}
 
-	return Object.assign({isCi: Boolean(env.CI)}, git.configuration({env, cwd}));
+	return {isCi: Boolean(env.CI), ...git.configuration({env, cwd})};
 };
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "xo": "^0.24.0"
   },
   "engines": {
-    "node": ">=6"
+    "node": ">=8.3"
   },
   "files": [
     "index.js",

diff --git a/services/github.js b/services/github.js
@@ -27,18 +27,16 @@ module.exports = {
 		const isPr = env.GITHUB_EVENT_NAME === 'pull_request';
 		const branch = parseBranch(env.GITHUB_REF);
 
-		return Object.assign(
-			{
-				name: 'GitHub Actions',
-				service: 'github',
-				commit: env.GITHUB_SHA,
-				isPr,
-				branch,
-				prBranch: isPr ? branch : undefined,
-				slug: env.GITHUB_REPOSITORY,
-				root: env.GITHUB_WORKSPACE,
-			},
-			isPr ? getPrEvent({env, cwd}) : undefined
-		);
+		return {
+			name: 'GitHub Actions',
+			service: 'github',
+			commit: env.GITHUB_SHA,
+			isPr,
+			branch,
+			prBranch: isPr ? branch : undefined,
+			slug: env.GITHUB_REPOSITORY,
+			root: env.GITHUB_WORKSPACE,
+			...(isPr ? getPrEvent({env, cwd}) : undefined),
+		};
 	},
 };
diff --git a/services/teamcity.js b/services/teamcity.js
@@ -37,15 +37,13 @@ module.exports = {
 		return Boolean(env.TEAMCITY_VERSION);
 	},
 	configuration({env, cwd}) {
-		return Object.assign(
-			{
-				name: 'TeamCity',
-				service: 'teamcity',
-				commit: env.BUILD_VCS_NUMBER,
-				build: env.BUILD_NUMBER,
-				slug: env.TEAMCITY_BUILDCONF_NAME,
-			},
-			getProperties({env, cwd})
-		);
+		return {
+			name: 'TeamCity',
+			service: 'teamcity',
+			commit: env.BUILD_VCS_NUMBER,
+			build: env.BUILD_NUMBER,
+			slug: env.TEAMCITY_BUILDCONF_NAME,
+			...getProperties({env, cwd}),
+		};
 	},
 };
diff --git a/test/services/appveyor.test.js b/test/services/appveyor.test.js
@@ -37,10 +37,7 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		appveyor.configuration({
-			env: Object.assign({}, env, {
-				APPVEYOR_PULL_REQUEST_NUMBER: '10',
-				APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH: 'pr-branch',
-			}),
+			env: {...env, APPVEYOR_PULL_REQUEST_NUMBER: '10', APPVEYOR_PULL_REQUEST_HEAD_REPO_BRANCH: 'pr-branch'},
 		}),
 		{
 			name: 'Appveyor',

diff --git a/test/services/bitrise.test.js b/test/services/bitrise.test.js
@@ -31,11 +31,7 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		bitrise.configuration({
-			env: Object.assign({}, env, {
-				BITRISE_PULL_REQUEST: '10',
-				BITRISEIO_GIT_BRANCH_DEST: 'master',
-				BITRISE_GIT_BRANCH: 'pr-branch',
-			}),
+			env: {...env, BITRISE_PULL_REQUEST: '10', BITRISEIO_GIT_BRANCH_DEST: 'master', BITRISE_GIT_BRANCH: 'pr-branch'},
 		}),
 		{
 			name: 'Bitrise',

diff --git a/test/services/buddy.test.js b/test/services/buddy.test.js
@@ -31,7 +31,7 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		buddy.configuration({
-			env: Object.assign({}, env, {BUDDY_EXECUTION_PULL_REQUEST_ID: 'pull/10', BUDDY_EXECUTION_BRANCH: undefined}),
+			env: {...env, BUDDY_EXECUTION_PULL_REQUEST_ID: 'pull/10', BUDDY_EXECUTION_BRANCH: undefined},
 		}),
 		{
 			name: 'Buddy',

diff --git a/test/services/buildkite.test.js b/test/services/buildkite.test.js
@@ -34,11 +34,12 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		buildkite.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				BUILDKITE_PULL_REQUEST: '10',
 				BUILDKITE_PULL_REQUEST_BASE_BRANCH: 'master',
 				BUILDKITE_BRANCH: 'pr-branch',
-			}),
+			},
 		}),
 		{
 			name: 'Buildkite',

diff --git a/test/services/circleci.test.js b/test/services/circleci.test.js
@@ -31,61 +31,52 @@ test('Push', t => {
 });
 
 test('PR 1.0', t => {
-	t.deepEqual(
-		circle.configuration({env: Object.assign({}, env, {CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'})}),
-		{
-			name: 'CircleCI',
-			service: 'circleci',
-			commit: '5678',
-			tag: 'tag_name',
-			build: '1234',
-			buildUrl: 'https://server.com/buildresult',
-			job: '1234.1',
-			branch: undefined,
-			pr: '10',
-			isPr: true,
-			prBranch: 'pr-branch',
-			slug: 'owner/repo',
-		}
-	);
+	t.deepEqual(circle.configuration({env: {...env, CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'}}), {
+		name: 'CircleCI',
+		service: 'circleci',
+		commit: '5678',
+		tag: 'tag_name',
+		build: '1234',
+		buildUrl: 'https://server.com/buildresult',
+		job: '1234.1',
+		branch: undefined,
+		pr: '10',
+		isPr: true,
+		prBranch: 'pr-branch',
+		slug: 'owner/repo',
+	});
 });
 
 test('PR 2.0', t => {
-	t.deepEqual(
-		circle.configuration({env: Object.assign({}, env, {CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'})}),
-		{
-			name: 'CircleCI',
-			service: 'circleci',
-			commit: '5678',
-			tag: 'tag_name',
-			build: '1234',
-			buildUrl: 'https://server.com/buildresult',
-			job: '1234.1',
-			branch: undefined,
-			pr: '10',
-			isPr: true,
-			prBranch: 'pr-branch',
-			slug: 'owner/repo',
-		}
-	);
+	t.deepEqual(circle.configuration({env: {...env, CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'}}), {
+		name: 'CircleCI',
+		service: 'circleci',
+		commit: '5678',
+		tag: 'tag_name',
+		build: '1234',
+		buildUrl: 'https://server.com/buildresult',
+		job: '1234.1',
+		branch: undefined,
+		pr: '10',
+		isPr: true,
+		prBranch: 'pr-branch',
+		slug: 'owner/repo',
+	});
 });
 
 test('PR 2.0 without pull uri', t => {
-	t.deepEqual(
-		circle.configuration({env: Object.assign({}, env, {CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'})}),
-		{
-			name: 'CircleCI',
-			service: 'circleci',
-			commit: '5678',
-			tag: 'tag_name',
-			build: '1234',
-			buildUrl: 'https://server.com/buildresult',
-			job: '1234.1',
-			branch: undefined,
-			pr: '10',
-			isPr: true,
-			prBranch: 'pr-branch',
-			slug: 'owner/repo',
-		}
-	);
+	t.deepEqual(circle.configuration({env: {...env, CIRCLE_BRANCH: 'pr-branch', CIRCLE_PR_NUMBER: '10'}}), {
+		name: 'CircleCI',
+		service: 'circleci',
+		commit: '5678',
+		tag: 'tag_name',
+		build: '1234',
+		buildUrl: 'https://server.com/buildresult',
+		job: '1234.1',
+		branch: undefined,
+		pr: '10',
+		isPr: true,
+		prBranch: 'pr-branch',
+		slug: 'owner/repo',
+	});
 });
diff --git a/test/services/cirrus.test.js b/test/services/cirrus.test.js
@@ -33,7 +33,7 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		cirrus.configuration({
-			env: Object.assign({}, env, {CIRRUS_PR: '239', CIRRUS_BASE_BRANCH: 'master', CIRRUS_BRANCH: 'pr-branch'}),
+			env: {...env, CIRRUS_PR: '239', CIRRUS_BASE_BRANCH: 'master', CIRRUS_BRANCH: 'pr-branch'},
 		}),
 		{
 			name: 'Cirrus CI',

diff --git a/test/services/codefresh.test.js b/test/services/codefresh.test.js
@@ -30,11 +30,7 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		codefresh.configuration({
-			env: Object.assign({}, env, {
-				CF_PULL_REQUEST_NUMBER: '10',
-				CF_PULL_REQUEST_TARGET: 'master',
-				CF_BRANCH: 'pr-branch',
-			}),
+			env: {...env, CF_PULL_REQUEST_NUMBER: '10', CF_PULL_REQUEST_TARGET: 'master', CF_BRANCH: 'pr-branch'},
 		}),
 		{
 			name: 'Codefresh',

diff --git a/test/services/drone.test.js b/test/services/drone.test.js
@@ -31,12 +31,13 @@ test('Push', t => {
 test('PR', t => {
 	t.deepEqual(
 		drone.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				DRONE_PULL_REQUEST: '10',
 				DRONE_BUILD_EVENT: 'pull_request',
 				DRONE_TARGET_BRANCH: 'master',
 				DRONE_SOURCE_BRANCH: 'pr-branch',
-			}),
+			},
 		}),
 		{
 			name: 'Drone',

diff --git a/test/services/github.test.js b/test/services/github.test.js
@@ -33,11 +33,12 @@ test('PR - with event.json file', t => {
 
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				GITHUB_EVENT_NAME: 'pull_request',
 				GITHUB_REF: '/refs/heads/pr-branch',
 				GITHUB_EVENT_PATH: eventFile,
-			}),
+			},
 		}),
 		{
 			name: 'GitHub Actions',
@@ -56,11 +57,12 @@ test('PR - with event.json file', t => {
 test('PR - with missing event.json file', t => {
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				GITHUB_EVENT_NAME: 'pull_request',
 				GITHUB_REF: '/refs/heads/pr-branch',
 				GITHUB_EVENT_PATH: '/tmp/null',
-			}),
+			},
 		}),
 		{
 			name: 'GitHub Actions',
@@ -79,10 +81,7 @@ test('PR - with missing event.json file', t => {
 test('PR - with missing event.json file path', t => {
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
-				GITHUB_EVENT_NAME: 'pull_request',
-				GITHUB_REF: '/refs/heads/pr-branch',
-			}),
+			env: {...env, GITHUB_EVENT_NAME: 'pull_request', GITHUB_REF: '/refs/heads/pr-branch'},
 		}),
 		{
 			name: 'GitHub Actions',
@@ -105,11 +104,12 @@ test('PR - with missing "pull_request" in event.json file', t => {
 
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				GITHUB_EVENT_NAME: 'pull_request',
 				GITHUB_REF: '/refs/heads/pr-branch',
 				GITHUB_EVENT_PATH: eventFile,
-			}),
+			},
 		}),
 		{
 			name: 'GitHub Actions',
@@ -132,11 +132,12 @@ test('PR - with missing "pull_request.base" in event.json file', t => {
 
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				GITHUB_EVENT_NAME: 'pull_request',
 				GITHUB_REF: '/refs/heads/pr-branch',
 				GITHUB_EVENT_PATH: eventFile,
-			}),
+			},
 		}),
 		{
 			name: 'GitHub Actions',
@@ -159,11 +160,12 @@ test('PR - with erronous branch names', t => {
 
 	t.deepEqual(
 		github.configuration({
-			env: Object.assign({}, env, {
+			env: {
+				...env,
 				GITHUB_EVENT_NAME: 'pull_request',
 				GITHUB_REF: '/refs/tags/pr-branch',
 				GITHUB_EVENT_PATH: eventFile,
-			}),
+			},
 		}),
 		{
 			name: 'GitHub Actions',