-
Notifications
You must be signed in to change notification settings - Fork 108
add docs re: transitive reachability #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Don't forget to add
|
Name | Link |
---|---|
🔨 Latest commit | dbd6a9f |
🔍 Latest deploy log | https://app.netlify.com/sites/semgrep-docs-prod/deploys/6814da7a4e591c00087554af |
😎 Deploy Preview | https://deploy-preview-2037--semgrep-docs-prod.netlify.app |
📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify site configuration.
### CLI | ||
|
||
Semgrep displays transitive reachability information in the CLI results as follows: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the subsequent content still accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this part is totally settled at this point
|
||
## Supported languages | ||
|
||
Semgrep currently performs transitive reachability analysis for JavaScript projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention the package managers we support here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But I have some questions (cc @bkettle who might know more)
- Are there any special steps to enable this feature, will there be anything in the settings page?
- How does the user know that Semgrep performed this analysis on their JavaScript repositories? Moving forward, this this type of analysis always "on"?
- Are there any caveats to this feature, like speed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments! I don't think we want to publish these yet, though; cc @k80kent for coordination on that
### CLI | ||
|
||
Semgrep displays transitive reachability information in the CLI results as follows: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this part is totally settled at this point
Co-authored-by: Ben Kettle <[email protected]>
…ps://github.com/semgrep/semgrep-docs into katiehorne/tec-270-transitive-reachability-docs
Preview
Please ensure