Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds an option to make DKIM validation optional #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qhenkart
Copy link
Contributor

Fixes

Issues seem to have been disabled for this Repo so I could not make one

Allows the inbound email SDK to support more email clients depending on the security requirements of the service. It also lays infrastructure for adding more functionality and configuration

A short description of what this PR does.

Simply takes an optional configuration struct that allows DKIM to be set to optional, so it will still check for failures but it will allow email clients that don't have DKIM set up

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • [n/a] I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@qhenkart
Copy link
Contributor Author

Looks like the build/test scripts are broken, unrelated to the update in this PR.

@qhenkart qhenkart force-pushed the optional-dkim branch 2 times, most recently from f431a42 to 08f8b35 Compare March 15, 2024 04:58
@qhenkart
Copy link
Contributor Author

@shrutiburman Is this repo still actively maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant