Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use constants for disposition #473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

SpencerC
Copy link

Fixes

Type checks arguments to SetDisposition, ensuring that the arguments are correct on the client side and developers don’t need to wait until runtime to see spelling mistakes.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@SpencerC
Copy link
Author

@tiwarishubham635 @sbansla LMK if this is something you'd consider or not. If not, would love to close and get off my list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant